WIP: [4.20] Add passt-binding-cni and PasstIPStackMigration to test allowlists#5458
Open
albarker-rh wants to merge 2 commits into
Open
WIP: [4.20] Add passt-binding-cni and PasstIPStackMigration to test allowlists#5458albarker-rh wants to merge 2 commits into
albarker-rh wants to merge 2 commits into
Conversation
CNV 4.20.19 introduced a new passt-binding-cni DaemonSet and PasstIPStackMigration feature gate. Update test allowlists to include these new components. Fixes: test_no_new_cnv_daemonset_added, test_default_featuregates_by_resource[kubevirt_cr], test_managed_cr_featuregate_reconcile[kubevirt_cr], test_no_new_cnv_pods_added, test_pods_scc_in_allowlist Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
for more information, see https://pre-commit.ci
|
Report bugs in Issues Welcome! 🎉This pull request will be automatically processed with the following features: 🔄 Automatic Actions
📋 Available CommandsPR Status Management
Review & Approval
Testing & Validation
Container Operations
Cherry-pick Operations
Branch Management
Custom Commands
Label Management
✅ Merge RequirementsThis PR will be automatically approved when the following conditions are met:
📊 Review ProcessApprovers and ReviewersApprovers:
Reviewers:
Available Labels
AI Features
Security Checks
💡 Tips
For more information, please refer to the project documentation or contact the maintainers. |
openshift-virtualization-qe-bot
added
the
tox:verify-tc-requirement-polarion:running
openshift-virtualization-qe-bot
added
tox:verify-tc-requirement-polarion:passed
Contributor
|
/lgtm @albarker-rh can you please address the DCO check issue? |
hmeir
suggested changes
Jul 2, 2026
| KUBEVIRT_CONSOLE_PLUGIN, | ||
| KUBEVIRT_MIGRATION_CONTROLLER, | ||
| KUBEVIRT_MIGRATION_OPERATOR, | ||
| PASST_BINDING_CNI, |
Contributor
There was a problem hiding this comment.
Are you sure that this FG should be enabled by default?
Contributor
|
/lgtm cancel Seems a leftover from Console T2 tests that are affecting our tests. Please refer to the Jira task associated for further details. |
Contributor
Author
|
/wip |
openshift-virtualization-qe-bot-2
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
CNV 4.20.19 introduced a new passt-binding-cni DaemonSet and PasstIPStackMigration feature gate. Update test allowlists to include these new components.
Which issue(s) this PR fixes:
Fixes: test_no_new_cnv_daemonset_added,
test_default_featuregates_by_resource[kubevirt_cr], test_managed_cr_featuregate_reconcile[kubevirt_cr], test_no_new_cnv_pods_added,
test_pods_scc_in_allowlist
Special notes for reviewer:
jira-ticket:
https://redhat.atlassian.net/browse/CNV-91964