chore: remove trailing commas from JSON and add linter rule#487
Open
platex-rehor-bot wants to merge 1 commit into
Open
chore: remove trailing commas from JSON and add linter rule#487platex-rehor-bot wants to merge 1 commit into
platex-rehor-bot wants to merge 1 commit into
Conversation
RHCLOUD-47771 Add eslint-plugin-jsonc with jsonc/comma-dangle rule set to "error" to prevent trailing commas in JSON files. Remove existing trailing commas from tsconfig and project.json files across all packages. Expand lint file patterns to cover all JSON files (*.json). This prevents future Nx upgrade blockers — Nx 22.7.1 has stricter JSON parsing that fails on trailing commas. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove trailing commas from all JSON files and add an ESLint rule to prevent future regressions. This is a preventive fix for the upcoming Nx 22.7.1 upgrade, which has stricter JSON parsing that fails on trailing commas.
RHCLOUD-47771
How to test locally
npm installnpm run lint— all 16 projects should passtsconfig.json) and runnpm run lintagain — thejsonc/comma-danglerule should flag it as an errorAnything reviewers should know?
eslint-plugin-jsonc(noteslint-plugin-jsonas originally suggested in the ticket) because:jsonc-eslint-parserfor JSON fileseslint-plugin-jsoncprovides the specificjsonc/comma-danglerule.eslintrc.json)prettier/prettieris disabled for JSON files to avoid conflicts with the jsonc ruleproject.jsonfiles expanded frompackage.json-only to*.jsonso all JSON files in each package are coveredChecklist
AI disclosure
Assisted by: Claude Code