Update EventParser.swift to Support CR LF

[Lakr233]

PR for #27

[Recouse]

Would you be able to add tests to verify your solution?

[Lakr233]

Hi. I have updated the code to support mixed CRLF and LFLF with tests. But I don't know if we should ever support mixed contents.

[Recouse]

I don't think mixed content will ever be a case.

I'll check the PR and merge it ASAP. Thank you!

[Recouse]

Overall, it looks good, but I'm not sure about the replaceSubrange method.

I think we could consider a solution with a custom split method, where we iterate through possible separators, find a range for the separator, split the data, and repeat the process. It will be a split method added in #26, but wrapped in another loop.

To optimize, we could also assume that there won't be mixed separators and use the one from the first iteration.

[Recouse]

This method has O(n+m) complexity. Won't it affect performance on a large amount of data?

[Lakr233]

Would you like to implement the optimization on your side? Kinda busy right now :P

[Recouse]

Sure, I'll give it a shot, and maybe I'll open a new PR

[stallent]

@Recouse think this PR will come in anytime soon? SSE spec says any of the 3 are supported "Lines must be separated by either a U+000D CARRIAGE RETURN U+000A LINE FEED (CRLF) character pair, a single U+000A LINE FEED (LF) character, or a single U+000D CARRIAGE RETURN (CR) character." so we are choking on spec compliant servers. Thanks! Have had terrific luck with your framework otherwise and appreciate you building it!

[wolfcon]

Maybe you can change Parser implementation from Data to String.
Use CharacterSet.whitespacesAndNewlines to avoid handle those.

[Recouse]

I specifically used Data to avoid unnecessary conversions between Data and String. I have some drafts that add CRLF support, I haven't had the time to focus on them full-time, but I'll probably open a new PR as soon as it's ready.

[Lakr233]

Maybe you can change Parser implementation from Data to String.

Use CharacterSet.whitespacesAndNewlines to avoid handle those.

You can't. Some of the data starts with white spaces. It was fixed earlier.

[wolfcon]

Maybe you can change Parser implementation from Data to String.
Use CharacterSet.whitespacesAndNewlines to avoid handle those.

You can't. Some of the data starts with white spaces. It was fixed earlier.

CharacterSet.newlines ... I have a mistake.

[Lakr233]

@Recouse I have replace all function with O(n) cplx so would you please update with me?

[Recouse]

I've been busy and haven't had time to review it yet. I'll take a look in the coming days, thanks for your contribution.

[Recouse]

Everything looks good to me. There's just one small improvement I'd like to suggest, removing the Data → String → Data conversions in the cleanMessageData(_:) method. I've made the changes and tested them. If you add me as a contributor in your repo, I could push the updates to this PR branch.

[Lakr233]

Everything looks good to me. There's just one small improvement I'd like to suggest, removing the Data → String → Data conversions in the cleanMessageData(_:) method. I've made the changes and tested them. If you add me as a contributor in your repo, I could push the updates to this PR branch.

Added.

[Recouse]

Oops, I accidentally pushed everything to my repo instead of yours.