Demonstration of possible reductions in library size#87
Open
mtrimpe wants to merge 1 commit intoReactiveRaven:masterfrom
mtrimpe:master
Open
Demonstration of possible reductions in library size#87mtrimpe wants to merge 1 commit intoReactiveRaven:masterfrom mtrimpe:master
mtrimpe wants to merge 1 commit intoReactiveRaven:masterfrom
mtrimpe:master
Conversation
…ze. Just a PoC; has bugs; will break build.
Collaborator
|
Good idea. I was looking into making the code simpler and shorter. These are some good suggestions. |
ghost
assigned
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was playing around and noticed some repetition in the code, so I thought I'd cook up a little example of how you can make some simple micro-DSLs in these cases to reduce library size.
It's getting late now so I'm just sending the pull request even though it's broken, very broken. It still shows what's possible though and achieves a bit of size reduction already.