Comfort Improvements: Github Link, Rom Path, Delete Shortcut#4
Open
Kunstbanause wants to merge 5 commits intoRareExports:mainfrom
Open
Comfort Improvements: Github Link, Rom Path, Delete Shortcut#4Kunstbanause wants to merge 5 commits intoRareExports:mainfrom
Kunstbanause wants to merge 5 commits intoRareExports:mainfrom
Conversation
Since the banjosbackpack.com website is down I tough it might be helpful to have a working link into the github project within the editor.
This adds the ROM path to the title bar when opening the rom at launch or after opening a rom manually from the file menu. This way the user knows which rom is currently being edited.
Kunstbanause
changed the title
Works in select, create, camera mode, etc Does nothing when no object is selected.
Kunstbanause
changed the title
Found a better place for the delete shortcut which does not intercept when editing text inputs
The old short cut interrupted when editing value fields with the delete key
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey guys, I hope this is not annoying to you. I wanted to create a pull request for a couple of comfort features that I have worked on:
A link to the github from within the editor (about window -> Shortcut: ctrl + h)
The ROM path and name are now shown in the title bar
Delete Key Shortcut that works in all the editing modes