Conversation
Save and restore vertical scroll position around the theme transition to prevent mobile browsers from scrolling when anchor innerHTML is restored. Switch textContent reads to innerText so the scramble animation only operates on visible text, fixing horizontal overflow caused by hidden responsive spans being included in the scramble string.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
window.scrollYbefore the scramble animation starts and restore it withbehavior: 'instant'at the end, preventing mobile browsers from scrolling when anchorinnerHTMLis restoredtextContentreads toinnerTextso the scramble only operates on visually rendered text — fixes horizontal overflow caused by the responsive CTA spans (sm:hidden/hidden sm:inline) both being included in the scramble string regardless of CSS visibility