Conversation
- Fix default config values in configmap - Fix args in operator yaml (remove "run") - Simplify spool volume - Prepend FQDN with protocol
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fix several issues in the K8s deployment manifests and Dockerfile that prevented successful deployment to a production RKE2 cluster with AMD MI325X GPUs.
Technical Details
rust:1.82torust:latest(edition 2024 required byredbcrate) and addedprotobuf-compiler+libprotobuf-devto the builder stage[partitions.default](TOML map) to[[partitions]]withname = "default"(TOML array-of-tables) to matchSlurmConfigparser; replaced[cluster] name = ...with top-levelcluster_name = ...; added requirednodesfieldrunsubcommand from args —--controller-addrand other flags are top-level clap args that must appear before any subcommand, andrunis already the defaultvolumeClaimTemplatewithemptyDirfor the spurctld StatefulSet to avoid PVC provisioning issues on clusters with certain storage backends (e.g., Longhorn)http://to the--controllerarg inspurrestd.yaml— spurrestd passes the address directly to tonic'sconnect()which requires a schemeTest Plan
docker build -f deploy/Dockerfilecompletes successfullyspurctldstarts and runs the scheduler loopspur-k8s-operatorconnects to spurctld and registers GPU nodesspurrestdconnects to spurctld without 500 errorsspur nodesshows registered MI325X node with correct resourcesTest Result
Deployed to a single-node RKE2 cluster with AMD MI325X GPUs. All Spur control plane components (
spurctld,spur-k8s-operator,spurrestd) start and communicate successfully. GPU node registered with correct CPU, memory, and GPU resources.