Skip to content

Fix issues #45, #46, #47, #48#49

Merged
powderluv merged 1 commit intomainfrom
fix/issues-45-46-47-48
Apr 6, 2026
Merged

Fix issues #45, #46, #47, #48#49
powderluv merged 1 commit intomainfrom
fix/issues-45-46-47-48

Conversation

@powderluv
Copy link
Copy Markdown
Collaborator

Summary

Test plan

  • 730 tests pass, 0 failures
  • cargo fmt --check clean
  • New tests: t50_92 (attach proto), t50_93 (config parsing), t50_94 (partition auto-assign), t50_95 (image basename fallback)
  • CI: fmt, clippy, build-and-test, cluster tests

Closes #45, #46, #47, #48

🤖 Generated with Claude Code

…uling, image resolution

- #45: sattach now provides interactive I/O via bidirectional streaming
  AttachJob RPC. Spawns a shell in the job's namespace with stdin/stdout
  forwarding. Old output-only mode available via --output-only flag.

- #46: CLI reads controller address from /etc/spur/spur.conf (or
  $SPUR_CONF) when SPUR_CONTROLLER_ADDR is not set. Priority:
  --controller > env var > config file > default. Single change in
  main.rs sets the env var before subcommand dispatch.

- #47: Nodes that don't match any partition hostlist are auto-assigned
  to the default partition on registration. Fixes jobs staying PENDING
  with Reason=Priority when dynamically-registered nodes had empty
  partition lists.

- #48: Agent's resolve_image() now tries basename fallback when an
  absolute path from the login node doesn't exist locally. Also adds
  ~/.spur/images fallback to match CLI behavior. Handles non-shared
  filesystem deployments.

Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

spur attach connects to job but does not provide interactive I/O

1 participant