Add regression tests for all closed issues#40
Merged
Conversation
Adds 17 new unit tests (706 → 723) ensuring every closed issue has a test that would catch a regression. Changes: - t52_config.rs t52_15–17: #37 — listen_addr preserved from config file; default is parseable; CLI --listen overrides config when set - t07_sched.rs t07_24–26: #27 — scheduler skips reserved nodes for unreserved jobs; reserved jobs land only on reserved nodes; no-reservation baseline - t05_queue.rs t05_9–11: #10 #22 — squeue excludes terminal jobs by default; --all includes them; cancelled is terminal - t50_core.rs t50_75–79: #25 single-node count >0; #26 reservation field on JobSpec; #28 reservation fields are updatable; #30 single-node name matches hostlist expansion; #36 NODELIST uses registered names - t50_core.rs t50_82–88: renumbered from t50_75–81 (no behaviour change) - container.rs: #35 #23 — error message includes directory searched; image_dir() returns system default without env var; image_dir() returns SPUR_IMAGE_DIR when set (agent and CLI now use same directory) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
17 new tests (706 → 723) ensuring every closed issue has a regression test. Issues without an existing test now have one that would catch a reintroduction of the bug.
listen_addrpreserved from config; CLI--listenoverrides when set--allincludes themreservationfield present and passable on JobSpecSPUR_IMAGE_DIRoverrides default; default is spur pathIssues not covered by unit tests (build/infra concerns): #7 (protoc version — CI only), #8 (CLI arg parsing — integration only), #9/#24 (command output format — integration only), #32 (actual process isolation — integration only).
Test plan
cargo test— 723 tests, 0 failurescargo fmt --check— clean🤖 Generated with Claude Code