Add federation forwarding and polish tests#38
Merged
Conversation
Implements the final item from the plan: federation peer forwarding in the scheduler loop, plus test coverage for all 5 polish features. Changes: - scheduler_loop.rs: forward unschedulable jobs to federation peer clusters via SlurmControllerClient::submit_job(). Tries peers in order; stops on first successful accept. Adds core_spec_to_proto() helper for the core→proto conversion required for RPC forwarding. - t50_core.rs: federation config parsing tests (t50_75–78), PMIx env var name tests (t50_79–81) — 7 new tests. - t07_sched.rs: federation forwarding decision tests (t07_18–20), power management state transition tests (t07_21–23) — 6 new tests. - t01_run.rs: srun step mode env var tests (t01_18–20) — 3 new tests. Total: 688 → 706 tests, 0 failures. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scheduler_loop.rs: when jobs remain unscheduled after local scheduling + preemption, unschedulable jobs are forwarded to configured peer clusters viaSlurmControllerClient::submit_job()core_spec_to_proto()helper (inverse ofproto_to_job_spec) needed for cross-cluster RPCTest plan
cargo test— 706 tests, 0 failurescargo fmt --check— cleancargo clippy— clean🤖 Generated with Claude Code