Skip to content

[CI] Increase rocDecode and rocJPEG Code Coverage#127

Closed
rocm-devops wants to merge 9 commits into
amd-stagingfrom
itrowbri/rocdecode-rocjpeg-test-coverage
Closed

[CI] Increase rocDecode and rocJPEG Code Coverage#127
rocm-devops wants to merge 9 commits into
amd-stagingfrom
itrowbri/rocdecode-rocjpeg-test-coverage

Conversation

@rocm-devops

Copy link
Copy Markdown

PR Details

Associated Jira Ticket Number/Link

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update
  • Continuous Integration

Technical details

Added/updated tests?

  • Yes
  • No, Does not apply to this PR.

Updated CHANGELOG?

  • Yes
  • No, Does not apply to this PR.

Added/Updated documentation?

  • Yes
  • No, Does not apply to this PR.

@rocm-devops

Copy link
Copy Markdown
Author

Code Coverage Report

Code Coverage Report

Tests Only

code coverage tests.png

Samples Only

code coverage samples.png

Tests + Samples

code coverage all.png

@rocm-devops

Copy link
Copy Markdown
Author

It looks like the MI200 machine (where the code coverage tests are run) skips the rocDecode and rocJPEG tests. The container doesn't appear to install rocJPEG or rocDecode which is why the test coverage is so low

-- Could NOT find rocDecode (missing: rocDecode_INCLUDE_DIR rocDecode_LIBRARY) 
-- Could NOT find rocJPEG (missing: rocJPEG_INCLUDE_DIR rocJPEG_LIBRARY)

@rocm-devops

Copy link
Copy Markdown
Author

Manual review required for 9a7c69
Assigned Auditors: @jalan

@rocm-devops

Copy link
Copy Markdown
Author

Manual review required for b8c923
Assigned Auditors: @deepatel

@rocm-devops

Copy link
Copy Markdown
Author

Manual review required for 3fe80b
Assigned Auditors: @anikitin

@rocm-devops

Copy link
Copy Markdown
Author

Manual review required for 9bf103
Assigned Auditors: @lpopescu

@rocm-devops

Copy link
Copy Markdown
Author

Manual review required for e6633d
Assigned Auditors: @deepatel

@rocm-devops

Copy link
Copy Markdown
Author

Manual review required for 560727
Assigned Auditors: @yuxuanli

@rocm-devops

Copy link
Copy Markdown
Author

Manual review required for 846b87
Assigned Auditors: @lpopescu

@rocm-devops

Copy link
Copy Markdown
Author

Manual review required for 8a8c2d
Assigned Auditors: @IAS

@rocm-devops

Copy link
Copy Markdown
Author

I enabled tests and samples of ROCm Release Compatibility, but I'm getting the following error:

 /opt/rocm-6.4.1/lib/llvm/bin/llvm-link: No such file or directory: '/opt/rocm-6.4.1/lib/llvm/lib/../runtimes/runtimes-bins/offload/libomptarget-amdgpu-gfx950.bc'
clang++: error: linker command failed with exit code 1 (use -v to see invocation)

Should I just leave it disabled for now?

@rocm-devops

Copy link
Copy Markdown
Author

I enabled tests and samples of ROCm Release Compatibility, but I'm getting the following error:

 /opt/rocm-6.4.1/lib/llvm/bin/llvm-link: No such file or directory: '/opt/rocm-6.4.1/lib/llvm/lib/../runtimes/runtimes-bins/offload/libomptarget-amdgpu-gfx950.bc'
clang++: error: linker command failed with exit code 1 (use -v to see invocation)

Should I just leave it disabled for now?

Disabled it and created an issue with this information for now: https://github.com/AMD-ROCm-Internal/rocprofiler-sdk-internal/issues/496

@amd-hsivasun

Copy link
Copy Markdown

Imported to rocm-systems

ammallya pushed a commit that referenced this pull request Oct 28, 2025
…null pointers for free operations (#127)

Update documentation to reflect that nullpointers can be recorded in free memory operations

[ROCm/rocprofiler-sdk commit: 73e72bb]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ias-review ready for 2nd review PR has one approval, needs second review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants