[rocprofv3] Reorganize rocprofv3.avail python package#122
Closed
rocm-devops wants to merge 5 commits into
Closed
Conversation
adding Python version candidates review fix fix test fix remove extra line fix the exception handle fix Lint fail fix installation adding checks to check version format disable test for address sanitizer
rocm-devops
requested review from
SrirakshaNag,
bgopesh,
jrmadsen and
t-tye
as code owners
Author
Author
Author
|
12 tasks
Contributor
|
Imported to ROCm/rocm-systems. |
amd-hsivasun
added
ready for merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Details
- Created new source/lib/python/rocprofv3/ directory with proper Python module
structure
- Added init.py and avail.py as a proper Python package
- Updated source/lib/python/CMakeLists.txt to include the new rocprofv3
subdirectory
- Updated rocprofv3-avail.py to use from rocprofv3 import avail instead of from
rocprofv3_avail_module import avail
- This creates a cleaner, more standard Python package import structure
Associated Jira Ticket Number/Link
What type of PR is this? (check all applicable)
Technical details
Adding a Python package for rocprofv3
Added/updated tests?
Updated CHANGELOG?
Added/Updated documentation?