Improve libelf diagnostics, fix bugs and typos#3278
Closed
systems-assistant[bot] wants to merge 1 commit into
Closed
Improve libelf diagnostics, fix bugs and typos#3278systems-assistant[bot] wants to merge 1 commit into
systems-assistant[bot] wants to merge 1 commit into
Conversation
Add elf_errmsg () to elf_begin (), elf_getphdrnum (), gelf_getphdr () failure messages so libelf error reasons are visible. In process_dbgapi_events (), switch on one_bit instead of stop_reason to correctly handle single bit stop-reasons. In log (), use vsnprintf with size+1 buffer and resize to avoid buffer overrun; replace vsprintf. In code_object_t::open (), add a bounds check when %-decoding the URI to avoid an out-of-bounds memory access. Check elf_strptr () for null before constructing a std::string. Fix typos. Change-Id: I71ea1641d21190d5c2d8525e9aaf3837cc35057b
lancesix
force-pushed
the
import/develop/ROCm_rocr_debug_agent/pr-27
branch
from
b7b3a51 to
8871ee8
Compare
Contributor
Contributor
|
Yes, we probably still want this. I'll take a TODO to handle the conflict now reported. |
Contributor
|
Downgraded to draft. Once it's ready we can flip it back. |
Contributor
|
This pull request has been inactive for 25 days and will be marked as stale. If you would like to keep this PR open, please:
This PR will be automatically closed in 5 days if no further activity occurs. |
Contributor
|
This pull request has been automatically closed due to inactivity (30 days with no updates). If you'd like to continue working on this, feel free to reopen the PR or create a new one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add elf_errmsg () to elf_begin (), elf_getphdrnum (), gelf_getphdr () failure messages so libelf error reasons are visible.
In process_dbgapi_events (), switch on one_bit instead of stop_reason to correctly handle single bit stop-reasons.
In log (), use vsnprintf with size+1 buffer and resize to avoid buffer overrun; replace vsprintf.
In code_object_t::open (), add a bounds check when %-decoding the URI to avoid an out-of-bounds memory access.
Check elf_strptr () for null before constructing a std::string.
Fix typos.
Change-Id: I71ea1641d21190d5c2d8525e9aaf3837cc35057b
🔁 Imported from ROCm/rocr_debug_agent#27
🧑💻 Originally authored by @ammallya