Add printing to test 10 for easier debugging#3275
Closed
systems-assistant[bot] wants to merge 2 commits into
Closed
Add printing to test 10 for easier debugging#3275systems-assistant[bot] wants to merge 2 commits into
systems-assistant[bot] wants to merge 2 commits into
Conversation
lumachad
force-pushed
the
import/develop/ROCm_rocr_debug_agent/pr-23
branch
from
b98dc34 to
da5adf0
Compare
Contributor
|
@amd-bfilipov Is this still required/desirable? |
Contributor
|
@amd-bfilipov Is this still being pursued? |
lumachad
force-pushed
the
import/develop/ROCm_rocr_debug_agent/pr-23
branch
from
da5adf0 to
4697761
Compare
Contributor
|
No longer pursued. We have testing output improvements ongoing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes logs and outputs easier to understand, we can now tell if the test failed because of executables crashing or was it because we didn't get expected output.
🔁 Imported from ROCm/rocr_debug_agent#23
🧑💻 Originally authored by @ammallya