[PC Sampling] Add gfx12xx PC Sampling Support by systems-assistant[bot] · Pull Request #186 · ROCm/rocm-systems

systems-assistant · 2025-08-07T22:46:17Z

PR Details

Initial GFX12 PC sampling support. The following is done as part of this PR:

Only host-trap is enabled, as Navi4x doesn't support stochastic PC sampling..
Still, we adapted parser's tests to verify stochastic data, as majority of code will be reused for later architecture.
Most of our integration tests were tied to gfx9 and 64 lane wide wavefront. This PR is using a wave_size (32 or 64) that depends on the underlying arch.

Notes

Please note that the WG_ID_Y and WG_ID_Z are meaningless for 1D dispatches. I still need to figure out if we can completely resolve this on the SDK side or we need 2nd level trap handler to deal with that. The ticket for tracking this effort is: SWDEV-542506

Associated Jira Ticket Number/Link

SWDEV-481151

What type of PR is this? (check all applicable)

Technical details

Added/updated tests?

Yes
No, Does not apply to this PR.

Updated CHANGELOG?

Yes
No, Does not apply to this PR.

Added/Updated documentation?

Yes
No, Does not apply to this PR.

🔁 Imported from ROCm/rocprofiler-sdk#132
🧑‍💻 Originally authored by @rocm-devops

- Create a document to describe enabling VCN and JPEG related metrics and tracing - Upload images and modify indexes. [ROCm/rocprofiler-systems commit: 13f315a]

ammarwa · 2025-08-22T11:13:15Z

Code Coverage Report

Tests Only

Samples Only

Tests + Samples

bwelton

We need to document the restrictions a bit more and address or create tickets to follow up on the TODO's (TODO W/O a ticket never get done).

vlaindic

Reverting original workloads.

The initial host-trap PC sampling support in SDK and V3. Introducing parser tests specific to GFX12. Reducing testing worklod to run on Navi4x in reasonable timeframe.

The GFX12 host-trap PC sampling support in SDK and V3. Introducing parser tests specific to GFX12. Co-authored-by: vlaindic_amdeng <vladimir.indic@amd.com> [rocm-systems] ROCm/rocm-systems#186 (commit 63a723a)

The GFX12 host-trap PC sampling support in SDK and V3. Introducing parser tests specific to GFX12. Co-authored-by: vlaindic_amdeng <vladimir.indic@amd.com>

Signed-off-by: gabrpham_amdeng <Gabriel.Pham@amd.com>

Signed-off-by: gabrpham_amdeng <Gabriel.Pham@amd.com> [ROCm/amdsmi commit: b72cd22]

…lt-dir (#186) * rocshmem_config.h needs to be in a similar directory structure for includes to work when building testers in build, and from an installed library * Do not change installed rocshmem.hpp

…lt-dir (#186) * rocshmem_config.h needs to be in a similar directory structure for includes to work when building testers in build, and from an installed library * Do not change installed rocshmem.hpp [ROCm/rocshmem commit: 63a7989]

[ROCm/rocjpeg commit: 5fea241]

* Adding wmma counters * add mi450 counters, changes from svaddire/MI450-Counters branch. * add gfx1250 for CPC_CPC_TCIU_IDLE --------- Co-authored-by: Sushma Vaddireddy <svaddire@amd.com> Co-authored-by: Venkateshwar Reddy Kandula <venkateshwar.kandula1306@gmail.com>

[ROCm/hipFile commit: b9d085d]

systems-assistant Bot added the imported pr label Aug 7, 2025

systems-assistant Bot requested review from ammarwa, bwelton, jrmadsen, t-tye and vlaindic as code owners August 7, 2025 22:46

systems-assistant Bot added the project: rocprofiler-sdk label Aug 7, 2025

amd-hsivasun added the ready for peer review label Aug 7, 2025

jayhawk-commits assigned vlaindic Aug 8, 2025

ApoKalipse-V self-requested a review August 8, 2025 20:58

systems-assistant Bot added the external contribution label Aug 10, 2025

jayhawk-commits added organization: ROCm and removed external contribution labels Aug 10, 2025

vlaindic added the ROCm-7.1 label Aug 11, 2025

ApoKalipse-V previously approved these changes Aug 11, 2025

View reviewed changes

ApoKalipse-V added ready for 2nd review and removed ready for peer review labels Aug 11, 2025

vlaindic changed the title ~~[PC Sampling][GFX12][Draft] PC Sampling Support~~ [PC Sampling][GFX12] PC Sampling Support Aug 12, 2025

vlaindic force-pushed the import/develop/ROCm_rocprofiler-sdk/vlaindic_gfx12-pcs branch from 28bd5cc to 7ac9788 Compare August 22, 2025 10:28

vlaindic assigned bwelton Aug 22, 2025

bwelton requested changes Aug 23, 2025

View reviewed changes

vlaindic force-pushed the import/develop/ROCm_rocprofiler-sdk/vlaindic_gfx12-pcs branch from 7ac9788 to fe0c828 Compare August 25, 2025 10:32

vlaindic reviewed Aug 25, 2025

View reviewed changes

vlaindic force-pushed the import/develop/ROCm_rocprofiler-sdk/vlaindic_gfx12-pcs branch from fe0c828 to 9963c39 Compare August 25, 2025 11:14

vlaindic requested a review from bwelton August 25, 2025 11:17

jrmadsen changed the title ~~[PC Sampling][GFX12] PC Sampling Support~~ [PC Sampling] Add gfx12xx PC Sampling Support Aug 26, 2025

jrmadsen self-assigned this Aug 26, 2025

systems-assistant Bot dismissed ApoKalipse-V’s stale review via 9963c39 August 26, 2025 17:01

vlaindic force-pushed the import/develop/ROCm_rocprofiler-sdk/vlaindic_gfx12-pcs branch 2 times, most recently from 1c695cb to 6860d8e Compare September 16, 2025 11:16

ApoKalipse-V approved these changes Sep 16, 2025

View reviewed changes

vlaindic force-pushed the import/develop/ROCm_rocprofiler-sdk/vlaindic_gfx12-pcs branch from 6860d8e to 337eebb Compare September 16, 2025 16:02

bgopesh added the ready to merge label Sep 16, 2025

vlaindic force-pushed the import/develop/ROCm_rocprofiler-sdk/vlaindic_gfx12-pcs branch 2 times, most recently from bf60216 to 45ce4dc Compare September 19, 2025 08:15

GFX12 PC Sampling support

9a7c5e2

The initial host-trap PC sampling support in SDK and V3. Introducing parser tests specific to GFX12. Reducing testing worklod to run on Navi4x in reasonable timeframe.

vlaindic force-pushed the import/develop/ROCm_rocprofiler-sdk/vlaindic_gfx12-pcs branch from 45ce4dc to 9a7c5e2 Compare September 19, 2025 16:45

ammarwa requested review from vlaindic and removed request for ammarwa, jrmadsen, t-tye and vlaindic September 19, 2025 17:07

vlaindic approved these changes Sep 19, 2025

View reviewed changes

vlaindic merged commit 63a723a into develop Sep 22, 2025
27 of 41 checks passed

vlaindic deleted the import/develop/ROCm_rocprofiler-sdk/vlaindic_gfx12-pcs branch September 22, 2025 11:17

sauverma93 pushed a commit that referenced this pull request Sep 26, 2025

GFX12 PC Sampling support (#186)

a0a8056

The GFX12 host-trap PC sampling support in SDK and V3. Introducing parser tests specific to GFX12. Co-authored-by: vlaindic_amdeng <vladimir.indic@amd.com>

ryang-amd pushed a commit that referenced this pull request Nov 7, 2025

GFX12 PC Sampling support (#186)

eb99d38

The GFX12 host-trap PC sampling support in SDK and V3. Introducing parser tests specific to GFX12. Co-authored-by: vlaindic_amdeng <vladimir.indic@amd.com>

ammallya pushed a commit that referenced this pull request Nov 17, 2025

[SWDEV-520754] Fixed str int concatenation issue (#186)

b72cd22

Signed-off-by: gabrpham_amdeng <Gabriel.Pham@amd.com>

ammallya pushed a commit that referenced this pull request Nov 18, 2025

[SWDEV-520754] Fixed str int concatenation issue (#186)

a98c8bc

Signed-off-by: gabrpham_amdeng <Gabriel.Pham@amd.com> [ROCm/amdsmi commit: b72cd22]

ammallya pushed a commit that referenced this pull request Nov 21, 2025

[SWDEV-520754] Fixed str int concatenation issue (#186)

51aad36

Signed-off-by: gabrpham_amdeng <Gabriel.Pham@amd.com> [ROCm/amdsmi commit: b72cd22]

ammallya pushed a commit that referenced this pull request Jan 30, 2026

Packaging - Update rocJPEG package dependencies (#186)

5fea241

ammallya pushed a commit that referenced this pull request Jan 30, 2026

Packaging - Update rocJPEG package dependencies (#186)

31d7611

[ROCm/rocjpeg commit: 5fea241]

ammallya pushed a commit that referenced this pull request Apr 9, 2026

INSTALL.md: Update nightly package URLs. (#186)

b9d085d

ammallya pushed a commit that referenced this pull request Apr 9, 2026

INSTALL.md: Update nightly package URLs. (#186)

7a270d7

[ROCm/hipFile commit: b9d085d]

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[PC Sampling] Add gfx12xx PC Sampling Support#186

[PC Sampling] Add gfx12xx PC Sampling Support#186
vlaindic merged 1 commit into
developfrom
import/develop/ROCm_rocprofiler-sdk/vlaindic_gfx12-pcs

systems-assistant Bot commented Aug 7, 2025 •

edited by vlaindic

Loading

Uh oh!

ammarwa commented Aug 22, 2025 •

edited

Loading

Code Coverage Report

Code Coverage Report

Tests Only

Samples Only

Tests + Samples

Uh oh!

bwelton left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vlaindic left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Conversation

systems-assistant Bot commented Aug 7, 2025 • edited by vlaindic Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Details

Associated Jira Ticket Number/Link

What type of PR is this? (check all applicable)

Technical details

Added/updated tests?

Updated CHANGELOG?

Added/Updated documentation?

Uh oh!

ammarwa commented Aug 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Coverage Report

Code Coverage Report

Tests Only

Samples Only

Tests + Samples

Uh oh!

bwelton left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vlaindic left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

systems-assistant Bot commented Aug 7, 2025 •

edited by vlaindic

Loading

ammarwa commented Aug 22, 2025 •

edited

Loading