Add function args serialization to RCCL buffer records #184
Closed
systems-assistant[bot] wants to merge 8 commits into
Closed
Add function args serialization to RCCL buffer records #184systems-assistant[bot] wants to merge 8 commits into
systems-assistant[bot] wants to merge 8 commits into
Conversation
systems-assistant
Bot
requested review from
MythreyaK,
SrirakshaNag,
ammarwa,
bgopesh,
bwelton,
jrmadsen and
t-tye
as code owners
abchoudh-amd
pushed a commit
that referenced
this pull request
Aug 8, 2025
* Initialize extremes to max and min values * Address review comment * Adding clang format [ROCm/rocprofiler-sdk commit: 90ae424]
github-actions
Bot
added
the
documentation
MythreyaK
force-pushed
the
import/develop/ROCm_rocprofiler-sdk/mkuriche_rccl-api-args
branch
10 times, most recently
from
a942283 to
6e78ba0
Compare
SrirakshaNag
added
ready for 2nd review
and removed
ready for peer review
ready for 2nd review
labels
MythreyaK
force-pushed
the
import/develop/ROCm_rocprofiler-sdk/mkuriche_rccl-api-args
branch
from
6e78ba0 to
67fdb0c
Compare
Member
|
PR waiting for IOMMU support on CI. |
ammallya
pushed a commit
that referenced
this pull request
Jan 21, 2026
ammallya
pushed a commit
that referenced
this pull request
Jan 21, 2026
[ROCm/rocshmem commit: 96336da]
Contributor
|
@MythreyaK Can we update this PR? |
MythreyaK
removed request for
SrirakshaNag,
ammarwa,
bgopesh,
bwelton,
jrmadsen and
t-tye
Member
|
Closing, will reopen with a rebase/updates soon. |
Member
|
(do not delete branch) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Details
Adds RCCL function parameter serialization. Requested by RCCL team.
No ticket yet, but they asked if nvtx ranges were supported. This request is not in this ticket / pr, but wanted to add this here.
Associated Jira Ticket Number/Link
SWDEV-528449
SWDEV-527517
What type of PR is this? (check all applicable)
Technical details
Adds RCCL function parameter serialization
Added/updated tests?
Updated CHANGELOG?
Added/Updated documentation?
🔁 Imported from ROCm/rocprofiler-sdk#129
🧑💻 Originally authored by @rocm-devops