Using semaphore to sync with all peer processes in finalization stage#169
Merged
ammarwa merged 8 commits intoAug 25, 2025
Conversation
systems-assistant
Bot
requested review from
SrirakshaNag and
bgopesh
as code owners
ammallya
pushed a commit
that referenced
this pull request
Aug 7, 2025
* Generate codecoverage comment as collapsible summary * Tweak markdown formatting [ROCm/rocprofiler-sdk commit: 58ecbd8]
ywang103-amd
pushed a commit
to ywang103-amd/rocm-systems
that referenced
this pull request
Aug 7, 2025
For compatibility with recent rocprofiler-sdk change. [ROCm/rocprofiler-systems commit: 2680ccc]
jayhawk-commits
pushed a commit
that referenced
this pull request
Aug 8, 2025
Update job_stats_sample.rst Co-authored-by: srawat <120587655+SwRaw@users.noreply.github.com> [ROCm/rdc commit: 4a230f0]
huanrwan-amd
force-pushed
the
import/develop/ROCm_rocprofiler-sdk/huanran_finalization_processes_sync
branch
from
4fc07a5 to
a381bc7
Compare
github-actions
Bot
added
the
documentation
subbul-amd
reviewed
Aug 15, 2025
Collaborator
|
huanrwan-amd
force-pushed
the
import/develop/ROCm_rocprofiler-sdk/huanran_finalization_processes_sync
branch
2 times, most recently
from
1983ccb to
cb60831
Compare
jayhawk-commits
pushed a commit
that referenced
this pull request
Aug 18, 2025
[ROCm/hip-tests commit: 6e2c871]
huanrwan-amd
force-pushed
the
import/develop/ROCm_rocprofiler-sdk/huanran_finalization_processes_sync
branch
from
cb60831 to
cff2b99
Compare
bwelton
approved these changes
Aug 19, 2025
bwelton
left a comment
bwelton
left a comment
Contributor
There was a problem hiding this comment.
I had reviewed and signed off on the original PR in the other repo. Signing off here.
jrmadsen
approved these changes
Aug 19, 2025
huanrwan-amd
force-pushed
the
import/develop/ROCm_rocprofiler-sdk/huanran_finalization_processes_sync
branch
from
cff2b99 to
b0ecb7d
Compare
[rocprofv3] Implement synchronization using POSIX semaphore in finalization
Apply suggestion by Copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
ammarwa
force-pushed
the
import/develop/ROCm_rocprofiler-sdk/huanran_finalization_processes_sync
branch
from
b0ecb7d to
33a8dab
Compare
ammarwa
deleted the
import/develop/ROCm_rocprofiler-sdk/huanran_finalization_processes_sync
branch
systems-assistant Bot
pushed a commit
to ROCm/rocprofiler-sdk
that referenced
this pull request
Aug 25, 2025
finalization stage (#169) * Using semaphore to sync with all peer processes in finalization stage [rocprofv3] Implement synchronization using POSIX semaphore in finalization * clang format code * clang 11 format code * Add process sync option for rocprofv3 * Default value of process sync is false * Update source/lib/rocprofiler-sdk-tool/tool.cpp Apply suggestion by Copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * update according to comments * add new line to helper.hpp [rocm-systems] ROCm/rocm-systems#169 (commit b645010)
ammallya
pushed a commit
that referenced
this pull request
Jan 21, 2026
Bumps [requests](https://github.com/psf/requests) from 2.32.3 to 2.32.4. - [Release notes](https://github.com/psf/requests/releases) - [Changelog](https://github.com/psf/requests/blob/main/HISTORY.md) - [Commits](psf/requests@v2.32.3...v2.32.4) --- updated-dependencies: - dependency-name: requests dependency-version: 2.32.4 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
ammallya
pushed a commit
that referenced
this pull request
Jan 21, 2026
Bumps [requests](https://github.com/psf/requests) from 2.32.3 to 2.32.4. - [Release notes](https://github.com/psf/requests/releases) - [Changelog](https://github.com/psf/requests/blob/main/HISTORY.md) - [Commits](psf/requests@v2.32.3...v2.32.4) --- updated-dependencies: - dependency-name: requests dependency-version: 2.32.4 dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> [ROCm/rocshmem commit: 49f7f1b]
ammallya
pushed a commit
that referenced
this pull request
Jan 30, 2026
…ocs/sphinx (#169) Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.21.1 to 1.22.0. - [Release notes](https://github.com/ROCm/rocm-docs-core/releases) - [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md) - [Commits](ROCm/rocm-docs-core@v1.21.1...v1.22.0) --- updated-dependencies: - dependency-name: rocm-docs-core[api_reference] dependency-version: 1.22.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
ammallya
pushed a commit
that referenced
this pull request
Jan 30, 2026
…ocs/sphinx (#169) Bumps [rocm-docs-core[api_reference]](https://github.com/ROCm/rocm-docs-core) from 1.21.1 to 1.22.0. - [Release notes](https://github.com/ROCm/rocm-docs-core/releases) - [Changelog](https://github.com/ROCm/rocm-docs-core/blob/develop/CHANGELOG.md) - [Commits](ROCm/rocm-docs-core@v1.21.1...v1.22.0) --- updated-dependencies: - dependency-name: rocm-docs-core[api_reference] dependency-version: 1.22.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> [ROCm/rocjpeg commit: a43e7f1]
ammallya
pushed a commit
that referenced
this pull request
Apr 9, 2026
Adds instructions on installing hipFile using the nightly packages and building aiscp.
ammallya
pushed a commit
that referenced
this pull request
Apr 9, 2026
Adds instructions on installing hipFile using the nightly packages and building aiscp. [ROCm/hipFile commit: 77d9fd5]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[rocprofv3] Implement synchronization using POSIX semaphore in finalization
PR Details
Associated Jira Ticket Number/Link
Previously in https://github.com/AMD-ROCm-Internal/rocprofiler-sdk-internal/pull/500
What type of PR is this? (check all applicable)
Technical details
This PR is to fix https://ontrack-internal.amd.com/browse/SWDEV-539022. In some workload, during the exiting stage, the framework uses a fast-fail pattern: if one process finishes, it kills all peer processes. E.g. in vLLM:
vllm/executor/multiproc_worker_utils.py:127:
This fix is using a POSIX semaphore to sync with peer processes, wait all peers finish and keep executing.
Added/updated tests?
Updated CHANGELOG?
Added/Updated documentation?
🔁 Imported from ROCm/rocprofiler-sdk#114
🧑💻 Originally authored by @rocm-devops