Skip to content

LWP100-1624 : non-preemptible scheduler locking#7

Open
rocm-devops wants to merge 24 commits into
developfrom
squiring/non-exclusive-locking
Open

LWP100-1624 : non-preemptible scheduler locking#7
rocm-devops wants to merge 24 commits into
developfrom
squiring/non-exclusive-locking

Conversation

@rocm-devops
Copy link
Copy Markdown

Original author: @psandhu

PR overview

LWP100-1624 : non-preemptible scheduler locking

Replace this paragraph with PR notes/details not covered by the commit
message below.

Testing

Describe how you have tested your code here.

Commit message

Replace this line with a short summary of the PR.

Replace this paragraph with a longer description of the PR.

sdquiring and others added 24 commits May 21, 2025 18:14
@rocm-devops rocm-devops requested a review from a team as a code owner July 8, 2025 21:30
@rocm-devops
Copy link
Copy Markdown
Author

Original commenter: @a1-mlselibci-npi

Generated Documentation

@rocm-devops
Copy link
Copy Markdown
Author

Original commenter: @a1-mlselibci-npi

Code Coverage Report for gfx942

Summary

Type Total Missed Master Missed Missed Change Coverage Master Coverage Coverage Change
Lines 49273 7346 7299 47 85.09% 85.14% -.05%
Functions 4747 757 755 2 84.05% 84.06% -.01%
Regions 31061 7590 7515 75 75.56% 75.65% -.09%
Branches 17445 4662 4610 52 73.28% 73.37% -.09%

This PR adds/edits 141 newly uncovered lines.

Artifacts

Commit Hashes

@rocm-devops
Copy link
Copy Markdown
Author

Original commenter: @a1-mlselibci-npi

CodeQL report

Results Summary

Full table of results
Tool Severity Code Location Line

Links

  • HTML
  • Sarif (for download and usage in conjunction with SARIF viewers)

@rocm-devops
Copy link
Copy Markdown
Author

Original commenter: @maemmett

Original review comment on lib/source/CodeGen/LowerFromKernelGraph.cpp at line 1246

Tidy this

@rocm-devops
Copy link
Copy Markdown
Author

Original commenter: @maemmett

Original review comment on lib/source/Scheduler.cpp at line 271

Remove this

@rocm-devops
Copy link
Copy Markdown
Author

Original commenter: @maemmett

Original review comment on lib/include/rocRoller/Scheduling/Scheduler_fwd.hpp at line 44

Is the exclusivity coded somewhere? Or just in the isNonPreemptibleDependency helper?

Might want to cross reference that routine in a comment here.

Also should these comments use the preemptible language?

@ROCm ROCm deleted a comment from rocm-devops Jul 9, 2025
@ROCm ROCm deleted a comment from rocm-devops Jul 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants