Check CCQE support in runtime instead of compiling#307
Open
QizhouZhang97 wants to merge 25 commits into
Open
Conversation
QizhouZhang97
force-pushed
the
dev/compat_ccqe
branch
from
d3a49c7 to
baa7fa4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
MORI must support both CCQE and non-CCQE ionic deployments with a single
binary. The previous build-time
IONIC_CCQEmacro forced a recompile perhost and broke whenever
libionic.soandmori_application.sowere out ofsync. This change moves the check to runtime: dlsym
ionic_dv_create_cq_ex; ifpresent, use CCQE; otherwise fall back to
ibv_create_cq_ex.