Skip to content

[Offload] Make EmissaryFortrt conditionally built when flang_rt is available #2486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
estewart08 merged 1 commit into from
May 12, 2026
+24 −13
Merged

[Offload] Make EmissaryFortrt conditionally built when flang_rt is available #2486

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 22 additions & 13 deletions offload/plugins-nextgen/common/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,22 @@ add_public_tablegen_target(PluginErrcodes)
if(OFFLOAD_ENABLE_EMISSARY_APIS)
set(emissary_sources
src/Emissary.cpp
src/EmissaryFortrt.cpp
src/EmissaryPrint.cpp
)
# EmissaryFortrt requires flang_rt; only include when available.
if(TARGET flang_rt.runtime.static)
set(OFFLOAD_HAS_EMISSARY_FORTRT TRUE)
else()
get_clang_resource_dir(CLANG_RESOURCE_LIBDIR PREFIX ${LLVM_BINARY_DIR} SUBDIR "lib/${LLVM_DEFAULT_TARGET_TRIPLE}")
string(REPLACE "${LLVM_LIBDIR_SUFFIX}" "" CLANG_RESOURCE_LIBDIR_NORMALIZED "${CLANG_RESOURCE_LIBDIR}")
find_library(LIBFLANG_RT flang_rt.runtime PATHS "${CLANG_RESOURCE_LIBDIR_NORMALIZED}")
if(LIBFLANG_RT)
set(OFFLOAD_HAS_EMISSARY_FORTRT TRUE)
endif()
endif()
if(OFFLOAD_HAS_EMISSARY_FORTRT)
list(APPEND emissary_sources src/EmissaryFortrt.cpp)
endif()
endif()

# NOTE: Don't try to build `PluginInterface` using `add_llvm_library` because we
Expand Down Expand Up @@ -45,18 +58,14 @@ endif()
# Include the RPC server from the `libc` project.
include(FindLibcCommonUtils)
target_link_libraries(PluginCommon PRIVATE llvm-libc-common-utilities)
if(OFFLOAD_ENABLE_EMISSARY_APIS AND TARGET flang_rt.runtime.static)
target_link_libraries(PluginCommon PRIVATE flang_rt.runtime.static
-L${CMAKE_BINARY_DIR}/../../lib -L${CMAKE_INSTALL_PREFIX}/lib)
else()
# This applies to runtimes standalone offload build.
# When we set LLVM_LIBDIR_SUFFIX for asan and perf builds, clang resource dir will
# use this suffix and it will not be a valid location for the flang_rt library. Replace
# the suffix with empty string to look in 'lib'.
get_clang_resource_dir(CLANG_RESOURCE_LIBDIR PREFIX ${LLVM_BINARY_DIR} SUBDIR "lib/${LLVM_DEFAULT_TARGET_TRIPLE}")
string(REPLACE ${LLVM_LIBDIR_SUFFIX} "" CLANG_RESOURCE_LIBDIR_NORMALIZED ${CLANG_RESOURCE_LIBDIR})
find_library(LIBFLANG_RT flang_rt.runtime PATHS "${CLANG_RESOURCE_LIBDIR_NORMALIZED}" REQUIRED)
target_link_libraries(PluginCommon PRIVATE ${LIBFLANG_RT})
if(OFFLOAD_ENABLE_EMISSARY_APIS AND OFFLOAD_HAS_EMISSARY_FORTRT)
if(TARGET flang_rt.runtime.static)
target_link_libraries(PluginCommon PRIVATE flang_rt.runtime.static
-L${CMAKE_BINARY_DIR}/../../lib -L${CMAKE_INSTALL_PREFIX}/lib)
else()
target_link_libraries(PluginCommon PRIVATE ${LIBFLANG_RT})
endif()
target_compile_definitions(PluginCommon PRIVATE OFFLOAD_HAS_EMISSARY_FORTRT)
endif()

if (OMPT_TARGET_DEFAULT AND LIBOMPTARGET_OMPT_SUPPORT)
Expand Down
2 changes: 2 additions & 0 deletions offload/plugins-nextgen/common/src/Emissary.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,9 @@ extern "C" emis_return_t Emissary(char *data) {
break;
}
case EMIS_ID_FORTRT: {
#ifdef OFFLOAD_HAS_EMISSARY_FORTRT
result = EmissaryFortrt(data, &ab);
#endif
break;
}
case EMIS_ID_PRINT: {
Expand Down
Loading