[Comgr][test] Disable compile_hip_with_libcxx_test#2447
Merged
Conversation
Will be re-enabled in #2444. Co-Authored-By: Claude <noreply@anthropic.com>
lamb-j
added a commit
that referenced
this pull request
May 7, 2026
Reverts the disable from #2447 now that the underlying issue (the test not passing -nostdinc++) is fixed by this PR. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Disable
compile_hip_with_libcxx_test-- it currently fails on systems with system libstdc++ at clang's default search path (manylinux/RHEL with gcc-toolset). Root cause and proper fix tracked in #2444 and #2445; will be re-enabled by #2444 once that lands.