Fix bash syntax in Makefile.hipfort that breaks environment variable inheritance#296
Open
marikurz-amd wants to merge 1 commit into
Open
Fix bash syntax in Makefile.hipfort that breaks environment variable inheritance#296marikurz-amd wants to merge 1 commit into
Makefile.hipfort that breaks environment variable inheritance#296marikurz-amd wants to merge 1 commit into
Conversation
…inheritance
Replace bash parameter expansion syntax (e.g., ${VAR:-default}) with
proper Make conditional assignment (?=). The bash syntax doesn't work
in GNU Make, causing ROCM_PATH, CUDA_PATH, and HIP_PLATFORM to become
empty strings instead of inheriting values from the environment.
Made-with: Cursor
ronlieb
approved these changes
May 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The
Makefile.hipfortuses bash shell parameter expansion syntax (${VAR:-default}) for setting default values, which does not work in GNU Make. This causesROCM_PATH,CUDA_PATH, andHIP_PLATFORMto become empty strings instead of inheriting values from the environment or using their defaults.This bug prevents users from using hipfort with just
module load rocm- they must explicitly passROCM_PATHon the command line as a workaround.Technical Details
bin/Makefile.hipfortReplace bash parameter expansion syntax with proper Make conditional assignment (
?=):Why this matters:
${VAR:-default}is bash syntax that Make interprets as a variable namedVAR:-default, which doesn't exist, resulting in an empty stringVAR ?= defaultis proper Make syntax meaning "set VAR to default only if not already defined"Submission Checklist