nicp2p Preset #228
Open
nicp2p Preset #228
+536
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gilbertlee-amd
requested changes
Jan 27, 2026
src/client/Presets/NicPeerToPeer.hpp
Outdated
| // Step 1: Generate standard round-robin tournament (maximum parallelism) | ||
| std::vector<std::vector<std::pair<int, int>>> fullSchedule; | ||
|
|
||
| if (N % 2 == 0) { |
Collaborator
There was a problem hiding this comment.
Is it necessary to break this down into 2 cases?
Can you just pad odd N to N+1, and then simply not create pair if playing against "dummy" team?
src/client/Presets/NicPeerToPeer.hpp
Outdated
| TransferBench::TestResults results; | ||
|
|
||
| // Calculate total IB devices per rank | ||
| // TODO: assert same # of NIC all ranks |
Collaborator
There was a problem hiding this comment.
If this is necessary for this preset, then add that check in. This can be checked by querying # nics per rank
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Adding a preset of internode p2p transfers
Technical Details
Transfers between any pair of NICs from all nodes will be executed serially. Results will be displayed and sorted.
Test Plan
Test Result
Example outputs
Submission Checklist