Add public is_current_run_pr_from_fork() wrapper for cache-type gating#5848
Open
subodh-dubey-amd wants to merge 1 commit into
Open
Add public is_current_run_pr_from_fork() wrapper for cache-type gating#5848subodh-dubey-amd wants to merge 1 commit into
subodh-dubey-amd wants to merge 1 commit into
Conversation
Follow-up to #5816. compute_pytorch_cache_type.py imported the module-private _is_current_run_pr_from_fork() from s3_buckets.py. Add a public is_current_run_pr_from_fork() wrapper and import that instead, so the helper is a supported entry point for reuse (per review feedback on #5816). Co-authored-by: Cursor <cursoragent@cursor.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #5816, addressing the review nit at #5816 (comment) (importing the private
_is_current_run_pr_from_forkacross files).Adds a public
is_current_run_pr_from_fork()wrapper ins3_buckets.pyand repointscompute_pytorch_cache_type.py(and its test mocks) to it. No behavior change.Test plan
compute_pytorch_cache_type_test.py(8 cases) passSubmission Checklist
Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.