[CI] Rename job to "Linux Build & Test"#191
Merged
Merged
Conversation
"Build & Test" is generic enough to collide with any other workflow's default job name. The required-status-check rule on amd-staging matches the bare check_run.name string, so renaming here means updating the ruleset entry too — see follow-up note below. Adding "Linux" makes room for an upcoming Windows/macOS expansion of the same workflow without further renaming. Did NOT add component-list qualifiers (LLVM/Comgr/translator) because the workflow will grow beyond those — keeping the name platform-shaped instead. ** ACTION REQUIRED on merge: ** The ruleset `amd-staging-psdb` (Settings → Rules → Rulesets) currently has required-check context `"SPIRV CI - amd-staging / Build & Test"`. After this lands, update that to `"Linux Build & Test"` so the required-check rule actually matches what the workflow emits. The rule is broken either way today (wrong context format), so this rename doesn't make things worse — it's the right time to also fix the rule.
lamb-j
added a commit
to ROCm/llvm-project
that referenced
this pull request
May 8, 2026
Generic name was at risk of colliding with other workflows. Adds "Linux" platform qualifier so future "Windows Build & Test" etc. can slot in without further renaming. Doesn't list components (LLVM, Comgr, translator) since the workflow will expand. ** ACTION REQUIRED on merge: ** The amd-staging ruleset's required-check context is currently "SPIRV CI - amd-staging / Build & Test" — never actually matched (the matcher uses bare check_run.name, see ROCm/SPIRV-LLVM-Translator#191). Update to "Linux Build & Test" so the rule fixes both the rename and the long-standing matcher bug at once. Companion change in the translator copy: ROCm/SPIRV-LLVM-Translator#191.
Contributor
🔴 New failures (0) — likely caused by this PR(none) 🟢 Fixed by this PR (0) — failing on baseline, passing here(none)
|
This was referenced May 8, 2026
lamb-j
added a commit
that referenced
this pull request
May 10, 2026
Re-creation of #190 (closed) on top of current amd-staging which includes the "Linux Build & Test" job rename (#191) and required-check ruleset update. Verifies end-to-end: - the renamed job emits "Linux Build & Test" check_run name - the updated required-check rule resolves to satisfied - the partition comment correctly classifies these test failures as 🔴 New failures Modifies CHECK directives in two passing transcoding tests with sentinel strings that won't appear in the actual output: - test/transcoding/fmax.ll - test/transcoding/CommonAddrspaceGlobalVar.ll Close without merge once verified.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"Build & Test"→"Linux Build & Test"."Build & Test"is generic and collides with any other workflow's default. Required-status-check rules match the bare check_run name, so the generic name is risky."Linux"to make room for future"Windows Build & Test"etc.The ruleset
amd-staging-psdb(Settings → Rules → Rulesets) currently has required-check context"SPIRV CI - amd-staging / Build & Test". That context format never actually matched (the matcher uses bare check_run.name, not the workflow-prefixed form), so the rule is silently broken today — non-admin merges are blocked, admins bypass.On merge, update the ruleset entry to
"Linux Build & Test"(bare job name, no workflow prefix, no event suffix). That fixes both the rename and the matching bug at once.Companion change for the llvm-project copy of this workflow: ROCm/llvm-project#2451.