Skip to content
This repository was archived by the owner on Jan 26, 2024. It is now read-only.

Use BUILD_TESTS to control OpenCL tests#137

Open
jpsamaroo wants to merge 1 commit intoROCm:mainfrom
jpsamaroo:jps/opencl-tests-unify
Open

Use BUILD_TESTS to control OpenCL tests#137
jpsamaroo wants to merge 1 commit intoROCm:mainfrom
jpsamaroo:jps/opencl-tests-unify

Conversation

@jpsamaroo
Copy link
Copy Markdown

It's unintuitive that you need to set both BUILD_TESTS=OFF and BUILD_TESTING=OFF to disable building all tests. This changes the OpenCL tests to instead just check BUILD_TESTS.

@vsytch
Copy link
Copy Markdown
Contributor

vsytch commented Aug 5, 2021

Thank you for bringing this issue up. We are currently testing this change internally. We are also planning to remove the bundled OpenCL ICD from the tree. I cannot give an ETA for this change, but most likely it will be publicly available with ROCm 5.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants