fix: backport manylinux_2_28 wheel build to v0.1.4 (post1 release)#528
Draft
kiran-thumma wants to merge 2 commits into
Draft
fix: backport manylinux_2_28 wheel build to v0.1.4 (post1 release)#528kiran-thumma wants to merge 2 commits into
kiran-thumma wants to merge 2 commits into
Conversation
--------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Backport PR #386 ("support glibc 2.28") onto v0.1.4 to produce
flydsl==0.1.4.post1wheels withmanylinux_2_27/manylinux_2_28platform tags.Problem
flydsl==0.1.4wheels on PyPI and AMD mirrors are only available asmanylinux_2_35(requires glibc 2.35+). This makes them uninstallable on:manylinux_2_28build container (glibc 2.28)Since
amd-aiter v0.1.13pinsRequires-Dist: flydsl==0.1.4, any downstream install of aiter fails on these platforms.Tracking issue: #527
Related issue: #396 (centos install failed — still open, same root cause)
What this PR does
v0.1.4tag — addsDockerfile.manylinux_2_28and updatesbuild-whl.yamlto build against glibc 2.280.1.4.post1— PyPI doesn't allow re-uploading the same versionExpected output
flydsl-0.1.4(existing)manylinux_2_35flydsl-0.1.4.post1(this PR)manylinux_2_27/manylinux_2_28Since
pip install flydsl==0.1.4auto-resolves to0.1.4.post1(PEP 440), no downstream pin changes needed.Test plan
skip_promote=trueto build wheels to stagingmanylinux_2_27_x86_64ormanylinux_2_28_x86_64manylinux_2_28container:amd-aiter v0.1.13installs cleanly with the new wheelAfter merge
0.1.4.post1wheels to PyPIflydsl==0.1.6back toflydsl==0.1.4