scripts/get_git: clean cached submodule dir on retry#2970
Open
felixjones wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cloning a submodule whose pinned commit is not the tip of its default branch leaves a shallow git dir with
--shallow-submodulesthat ends up breaking fetches of that commit (git fails with 'upload-pack: not our ref').Removing the cached .git/modules entry and the directory before reinit performs a clean full clone that resolves the pinned commit
Testing
I encountered this 'upload-pack: not our ref' when experimenting with gamescope, which pins wlroots to a commit on a non-default branch - I was deleting the cached .git/modules/ directory over and over and I figured if it's in this Failed branch it's safe to delete
.git/modules/${submodule}Additional Context
It could be that I suck at git and got into this broken state myself, but it was consistent when I was messing around with gamescope
AI Usage
NO