Skip to content

Rename ExploitIQ/Agent morpheus to Exploit Intelligence#258

Open
TamarW0 wants to merge 19 commits into
mainfrom
APPENG-5387
Open

Rename ExploitIQ/Agent morpheus to Exploit Intelligence#258
TamarW0 wants to merge 19 commits into
mainfrom
APPENG-5387

Conversation

@TamarW0

@TamarW0 TamarW0 commented Jun 21, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@vbelouso

vbelouso commented Jun 21, 2026

Copy link
Copy Markdown
Collaborator

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@TamarW0

TamarW0 commented Jun 21, 2026

Copy link
Copy Markdown
Collaborator Author

/retest

@exploit-iq-pac

Copy link
Copy Markdown

Caution

There are some errors in your PipelineRun template.

PipelineRun Error
vulnerability-analysis-on-pr CEL expression evaluation error: expression "event == \"pull_request\" &&\n!body.pull_request.draft &&\n(target_branch == \"main\" || target_branch == \"rh-aiq-main\") &&\n(\"src/**\".pathChanged() || \"metrics_lib/**\".pathChanged() || \"pyproject.toml\".pathChanged() || \"uv.lock\".pathChanged() || \"Dockerfile\".pathChanged() || \".dockerignore\".pathChanged())\n" failed to evaluate: no such key: pull_request

@vbelouso

Copy link
Copy Markdown
Collaborator

/retest vulnerability-analysis-on-pr

@TamarW0

TamarW0 commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator Author

/retest

@vbelouso

Copy link
Copy Markdown
Collaborator

@TamarW0 Could we please refrain from updating the kustomize/README.md file in this pull request or rebase it later?
I'm currently preparing major changes to this readme so it will be difficult for us to resolve conflicts.

@TamarW0 TamarW0 added the WIP label Jun 25, 2026
@TamarW0 TamarW0 removed the WIP label Jun 25, 2026
@TamarW0 TamarW0 requested review from vbelouso and zvigrinberg June 25, 2026 09:08

@zvigrinberg zvigrinberg left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @TamarW0
There are comments that should be addressed, changed , and verify couple of things.
In addition to that, need to verify an E2E OCP deployment on new namespace, to see that nothing is missing/left off/forgotten...

Comment thread kustomize/base/exploit-iq-config.yml Outdated
plugin_config:
source: Product Security research
endpoint: CALLBACK_URL_PLACEHOLDER/api/v1/vulnerabilities/{vuln_id}/comments
endpoint: https://exploit-iq-client.tw-iq.svc:8443/api/v1/vulnerabilities/{vuln_id}/comments

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TamarW0 Please revert to placeholder.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Comment thread kustomize/base/exploit-iq-config.yml Outdated
cve_http_output:
_type: cve_http_output
url: CALLBACK_URL_PLACEHOLDER
url: https://exploit-iq-client.tw-iq.svc:8443

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TamarW0 Please revert to placeholder.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Comment thread .gitignore Outdated

kustomize/components/oidc-ca/*.crt

kustomize/components/oidc-ca/*.crt

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TamarW0 Remove duplication.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

{
"id": 1,
"question": "{\"image\":{\"name\":\"nvcr.io\/nvidia\/morpheus\/morpheus\",\"tag\":\"23.11-runtime\",\"source_info\":[{\"type\":\"code\",\"git_repo\":\"https:\/\/github.com\/nv-morpheus\/Morpheus.git\",\"ref\":\"v23.11.01\",\"include\":[\"**\/*.cpp\",\"**\/*.cu\",\"**\/*.cuh\",\"**\/*.h\",\"**\/*.hpp\",\"**\/*.ipynb\",\"**\/*.py\",\"**\/*Dockerfile\"],\"exclude\":[\"tests\/**\/*\"]},{\"type\":\"doc\",\"git_repo\":\"https:\/\/github.com\/nv-morpheus\/Morpheus.git\",\"ref\":\"v23.11.01\",\"include\":[\"**\/*.md\",\"docs\/**\/*.rst\"]}],\"sbom_info\":{\"_type\":\"file\",\"file_path\":\"data\/sboms\/nvcr.io\/nvidia\/morpheus\/morpheus:v23.11.01-runtime.sbom\"}},\"scan\":{\"vulns\":[{\"vuln_id\":\"GHSA-3f63-hfp8-52jq\"},{\"vuln_id\":\"CVE-2023-50782\"}]}}",
"question": "{\"image\":{\"name\":\"nvcr.io\/nvidia\/morpheus\/morpheus\",\"tag\":\"23.11-runtime\",\"source_info\":[{\"type\":\"code\",\"git_repo\":\"https:\/\/github.com\/nv-\/Morpheus.git\",\"ref\":\"v23.11.01\",\"include\":[\"**\/*.cpp\",\"**\/*.cu\",\"**\/*.cuh\",\"**\/*.h\",\"**\/*.hpp\",\"**\/*.ipynb\",\"**\/*.py\",\"**\/*Dockerfile\"],\"exclude\":[\"tests\/**\/*\"]},{\"type\":\"doc\",\"git_repo\":\"https:\/\/github.com\/nv-morpheus\/Morpheus.git\",\"ref\":\"v23.11.01\",\"include\":[\"**\/*.md\",\"docs\/**\/*.rst\"]}],\"sbom_info\":{\"_type\":\"file\",\"file_path\":\"data\/sboms\/nvcr.io\/nvidia\/morpheus\/morpheus:v23.11.01-runtime.sbom\"}},\"scan\":{\"vulns\":[{\"vuln_id\":\"GHSA-3f63-hfp8-52jq\"},{\"vuln_id\":\"CVE-2023-50782\"}]}}",

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TamarW0 This file is irrelevant.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reverted

Comment thread src/vuln_analysis/register.py Outdated
def convert_str_to_agent_morpheus_input(input: str) -> AgentMorpheusInput:
logger.debug("Converting JSON string input to AgentMorpheusInput (length: %d)", len(input))
def convert_str_to_exploit_iq_input(input: str) -> ExploitIqInput:
logger.debug("Converting JSON string input to AExploitIqInput (length: %d)", len(input))

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TamarW0 You have a typo here

Suggested change
logger.debug("Converting JSON string input to AExploitIqInput (length: %d)", len(input))
logger.debug("Converting JSON string input to ExploitIqInput (length: %d)", len(input))

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Comment thread kustomize/base/exploit_iq_client.yaml Outdated
containerPort: 8080
env:
- name: QUARKUS_REST-CLIENT_MORPHEUS_URL
- name: QUARKUS_REST_CLIENT_EXPLOIT_IQ_URL

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TamarW0 There was originally a dash in here, now you replaced it with an underscore, it might break things, please verify that it's correlated with new property name.

@zvigrinberg zvigrinberg Jun 28, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

usally the . is replaced with one underscore, and hyphen/dash replaced with double underscore (__) if the two words delimited by the dash are enclosed by a double quotes.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested this and changed back to "-" to align to the correct property

Comment thread kustomize/base/exploit_iq_client.yaml
Comment thread kustomize/base/exploit_iq_service.yaml Outdated
Comment thread kustomize/base/exploit_iq_service.yaml Outdated
@TamarW0

TamarW0 commented Jun 28, 2026

Copy link
Copy Markdown
Collaborator Author

/retest

@zvigrinberg zvigrinberg left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @TamarW0 ,
There is still some comments, and also something not related directly:
There is the exploit-iq-models repo to install the LLM using helm chart.
need to add to a new commit explicitly the submodule ( already in .gitmodules file) and verify in the kustomize/README.md file that the paths in the helm upgrade command in the exploit-iq-models module are aligned with the module repo paths.

 git submodule add https://github.com/RHEcosystemAppEng/exploit-iq-models.git exploit-iq-models
  git commit -m "Register exploit-iq-models submodule"

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TamarW0 To check consistency of brand renaming here and in model classes, please run agent locally, and then download the openapi spec from http://localhost:26466/openapi.json, then Just beautify it, and put it updated in the PR, and then re-compare to see if all casing and brand name renames are consistent.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TamarW0 Please check also the nginx folder in the kustomize/base/ directory, as this is what we're actually using for the deployed NginX.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont see anything to change there

Comment thread kustomize/README.md

- [GnuPG](https://www.gnupg.org/download/)
- [SOPS](https://github.com/getsops/sops/releases)
- The private decryption key from the Bitwarden vault entry **ExploitIQ Tests Deployment Variant Private Key for Decryption**

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TamarW0 Please go to bitwarden and rename accordingly the secret entry name.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TamarW0 This file should be restored to the main revision. shouldn't be under this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants