Rename ExploitIQ/Agent morpheus to Exploit Intelligence#258
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
|
/retest |
|
Caution There are some errors in your PipelineRun template.
|
|
/retest vulnerability-analysis-on-pr |
|
/retest |
|
@TamarW0 Could we please refrain from updating the kustomize/README.md file in this pull request or rebase it later? |
zvigrinberg
left a comment
There was a problem hiding this comment.
Hi @TamarW0
There are comments that should be addressed, changed , and verify couple of things.
In addition to that, need to verify an E2E OCP deployment on new namespace, to see that nothing is missing/left off/forgotten...
| plugin_config: | ||
| source: Product Security research | ||
| endpoint: CALLBACK_URL_PLACEHOLDER/api/v1/vulnerabilities/{vuln_id}/comments | ||
| endpoint: https://exploit-iq-client.tw-iq.svc:8443/api/v1/vulnerabilities/{vuln_id}/comments |
| cve_http_output: | ||
| _type: cve_http_output | ||
| url: CALLBACK_URL_PLACEHOLDER | ||
| url: https://exploit-iq-client.tw-iq.svc:8443 |
|
|
||
| kustomize/components/oidc-ca/*.crt | ||
|
|
||
| kustomize/components/oidc-ca/*.crt |
| { | ||
| "id": 1, | ||
| "question": "{\"image\":{\"name\":\"nvcr.io\/nvidia\/morpheus\/morpheus\",\"tag\":\"23.11-runtime\",\"source_info\":[{\"type\":\"code\",\"git_repo\":\"https:\/\/github.com\/nv-morpheus\/Morpheus.git\",\"ref\":\"v23.11.01\",\"include\":[\"**\/*.cpp\",\"**\/*.cu\",\"**\/*.cuh\",\"**\/*.h\",\"**\/*.hpp\",\"**\/*.ipynb\",\"**\/*.py\",\"**\/*Dockerfile\"],\"exclude\":[\"tests\/**\/*\"]},{\"type\":\"doc\",\"git_repo\":\"https:\/\/github.com\/nv-morpheus\/Morpheus.git\",\"ref\":\"v23.11.01\",\"include\":[\"**\/*.md\",\"docs\/**\/*.rst\"]}],\"sbom_info\":{\"_type\":\"file\",\"file_path\":\"data\/sboms\/nvcr.io\/nvidia\/morpheus\/morpheus:v23.11.01-runtime.sbom\"}},\"scan\":{\"vulns\":[{\"vuln_id\":\"GHSA-3f63-hfp8-52jq\"},{\"vuln_id\":\"CVE-2023-50782\"}]}}", | ||
| "question": "{\"image\":{\"name\":\"nvcr.io\/nvidia\/morpheus\/morpheus\",\"tag\":\"23.11-runtime\",\"source_info\":[{\"type\":\"code\",\"git_repo\":\"https:\/\/github.com\/nv-\/Morpheus.git\",\"ref\":\"v23.11.01\",\"include\":[\"**\/*.cpp\",\"**\/*.cu\",\"**\/*.cuh\",\"**\/*.h\",\"**\/*.hpp\",\"**\/*.ipynb\",\"**\/*.py\",\"**\/*Dockerfile\"],\"exclude\":[\"tests\/**\/*\"]},{\"type\":\"doc\",\"git_repo\":\"https:\/\/github.com\/nv-morpheus\/Morpheus.git\",\"ref\":\"v23.11.01\",\"include\":[\"**\/*.md\",\"docs\/**\/*.rst\"]}],\"sbom_info\":{\"_type\":\"file\",\"file_path\":\"data\/sboms\/nvcr.io\/nvidia\/morpheus\/morpheus:v23.11.01-runtime.sbom\"}},\"scan\":{\"vulns\":[{\"vuln_id\":\"GHSA-3f63-hfp8-52jq\"},{\"vuln_id\":\"CVE-2023-50782\"}]}}", |
| def convert_str_to_agent_morpheus_input(input: str) -> AgentMorpheusInput: | ||
| logger.debug("Converting JSON string input to AgentMorpheusInput (length: %d)", len(input)) | ||
| def convert_str_to_exploit_iq_input(input: str) -> ExploitIqInput: | ||
| logger.debug("Converting JSON string input to AExploitIqInput (length: %d)", len(input)) |
There was a problem hiding this comment.
@TamarW0 You have a typo here
| logger.debug("Converting JSON string input to AExploitIqInput (length: %d)", len(input)) | |
| logger.debug("Converting JSON string input to ExploitIqInput (length: %d)", len(input)) |
| containerPort: 8080 | ||
| env: | ||
| - name: QUARKUS_REST-CLIENT_MORPHEUS_URL | ||
| - name: QUARKUS_REST_CLIENT_EXPLOIT_IQ_URL |
There was a problem hiding this comment.
@TamarW0 There was originally a dash in here, now you replaced it with an underscore, it might break things, please verify that it's correlated with new property name.
There was a problem hiding this comment.
usally the . is replaced with one underscore, and hyphen/dash replaced with double underscore (__) if the two words delimited by the dash are enclosed by a double quotes.
There was a problem hiding this comment.
tested this and changed back to "-" to align to the correct property
|
/retest |
zvigrinberg
left a comment
There was a problem hiding this comment.
Hi @TamarW0 ,
There is still some comments, and also something not related directly:
There is the exploit-iq-models repo to install the LLM using helm chart.
need to add to a new commit explicitly the submodule ( already in .gitmodules file) and verify in the kustomize/README.md file that the paths in the helm upgrade command in the exploit-iq-models module are aligned with the module repo paths.
git submodule add https://github.com/RHEcosystemAppEng/exploit-iq-models.git exploit-iq-models
git commit -m "Register exploit-iq-models submodule"There was a problem hiding this comment.
@TamarW0 To check consistency of brand renaming here and in model classes, please run agent locally, and then download the openapi spec from http://localhost:26466/openapi.json, then Just beautify it, and put it updated in the PR, and then re-compare to see if all casing and brand name renames are consistent.
There was a problem hiding this comment.
@TamarW0 Please check also the nginx folder in the kustomize/base/ directory, as this is what we're actually using for the deployed NginX.
There was a problem hiding this comment.
I dont see anything to change there
|
|
||
| - [GnuPG](https://www.gnupg.org/download/) | ||
| - [SOPS](https://github.com/getsops/sops/releases) | ||
| - The private decryption key from the Bitwarden vault entry **ExploitIQ Tests Deployment Variant Private Key for Decryption** |
There was a problem hiding this comment.
@TamarW0 Please go to bitwarden and rename accordingly the secret entry name.
There was a problem hiding this comment.
@TamarW0 This file should be restored to the main revision. shouldn't be under this PR.
No description provided.