Appeng 5540 Enhancement and bug fixes for adding manifest_path and ecosystem fields to agentic logic: #272
Open
gnetanel wants to merge 5 commits into
Conversation
Collaborator
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Collaborator
Author
|
/test vulnerability-analysis-on-pr |
zvigrinberg
requested changes
Jun 30, 2026
zvigrinberg
left a comment
zvigrinberg
left a comment
Collaborator
There was a problem hiding this comment.
Hi @gnetanel ,
Please see my comments.
added 4 commits
July 1, 2026 09:54
…cosystem fields to agentic logic
…of class DocumentEmbedding
gnetanel
force-pushed
the
APPENG-5540_mixed_repo_part_2_to_deliver
branch
from
3d6b1e8 to
7b7f679
Compare
Collaborator
Author
|
/test vulnerability-analysis-on-pr |
gnetanel
force-pushed
the
APPENG-5540_mixed_repo_part_2_to_deliver
branch
from
7b7f679 to
4ef3712
Compare
Collaborator
Author
|
/test vulnerability-analysis-on-pr |
2 similar comments
Collaborator
|
/test vulnerability-analysis-on-pr |
Collaborator
Author
|
/test vulnerability-analysis-on-pr |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verify & test the following:
Request include only ecosystem without manifest path
Expected behavior: no autodetection is done, yet - verification is done that expected manifest file exist
Request include only manifest path without ecosystem
Expected behavior: autodetection is done as before, yet - it is done on given path
Manifest Path parameter verification:
Verify that path does not include ".." characters, in case it does, fail the request (prevent attach on other directories on the host)
In case path does not exist fail the request with clear error
Ecosystem parameter verification:
In case manifest file not available for the ecosystem, fail the operation with clear error message. (do not retry finding ecosystem automatically)
In addition resolve the review comment named 'finding 3', 'finding 4' and finding 7' from the original PR that introduced the multi-repo feature.