Skip to content

fix(credentials): validate user and key fields when parsing credentials file#268

Merged
r2dedios merged 1 commit into
release-0.6from
feat/validate-credentials-parsing
Jun 23, 2026
Merged

fix(credentials): validate user and key fields when parsing credentials file#268
r2dedios merged 1 commit into
release-0.6from
feat/validate-credentials-parsing

Conversation

@r2dedios

Copy link
Copy Markdown
Collaborator

Summary

  • Validate that user and key fields are not empty when parsing the credentials file in ReadCloudAccounts
  • Accounts with missing credentials are skipped and reported via ErrMissingCredentials
  • Scanner and Agent callers log a warning for skipped accounts but continue with valid ones
  • If no valid accounts remain, the error propagates as before (fatal)

Test plan

  • make go-unit-tests — all pass, 100% coverage on credentials
  • make lint — 0 issues
  • make local-build — compiles clean
  • Tests cover: missing user, missing key, mixed valid/invalid accounts

Closes #215

@r2dedios r2dedios self-assigned this Jun 23, 2026
@r2dedios r2dedios added the enhancement New feature or request label Jun 23, 2026
@r2dedios r2dedios added this to the v0.6 milestone Jun 23, 2026
@r2dedios r2dedios linked an issue Jun 23, 2026 that may be closed by this pull request
@r2dedios r2dedios merged commit 8fe0a9d into release-0.6 Jun 23, 2026
4 checks passed
@r2dedios r2dedios linked an issue Jun 23, 2026 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve credentials file parsing

1 participant