Skip to content
This repository was archived by the owner on Jun 30, 2026. It is now read-only.

fix(rh-sre): align fleet-inventory with Lightspeed MCP tool schemas#126

Merged
dmartinol merged 4 commits into
RHEcosystemAppEng:mainfrom
dmartinol:fix/124-fleet-inventory-mcp-tool-params
Jun 23, 2026
Merged

fix(rh-sre): align fleet-inventory with Lightspeed MCP tool schemas#126
dmartinol merged 4 commits into
RHEcosystemAppEng:mainfrom
dmartinol:fix/124-fleet-inventory-mcp-tool-params

Conversation

@dmartinol

Copy link
Copy Markdown
Collaborator

Fixes #124

Summary

Correct the fleet-inventory skill so documented MCP tools and parameters match the live Red Hat Lightspeed MCP schemas. Fleet discovery now uses inventory__list_hosts (with per_page/page pagination) instead of parameterless get_host_details. CVE-affected system queries use cve (not cve_id) with limit/offset. Parameter reference, examples, and insights-api.md are updated accordingly.

Pack(s) affected

  • ocp-admin
  • rh-ai-engineer
  • rh-automation
  • rh-basic
  • rh-developer
  • rh-sre
  • rh-virt
  • Other / repo-wide

Change type

  • New skill
  • New agent
  • New pack
  • Update existing skill / agent
  • MCP server config (mcps.json)
  • Docs / README
  • CI / tooling
  • Federation (external pack)

Contribution method

  • Created/imported with /agentic-contribution-skill
  • Manual contribution (validated with make validate + make validate-skill-design-changed)

Pack-persona alignment (new skills only)

N/A — existing skill update.

AGENTS.md compliance

  • Agents orchestrate skills; no direct MCP/tool calls in agents
  • Skills are single-purpose task executors
  • Skills encapsulate all tool access (MCP tools invoked only inside skills)
  • Document consultation: file is read with the Read tool, then declared to the user
  • No credentials hardcoded; env vars used via ${VAR} references
  • Human-in-the-loop confirmation added for any destructive or critical operations

Validation

  • make validate passes locally
  • New/changed skills have valid YAML frontmatter (name, description)
  • New/changed agents have valid YAML frontmatter (name, description)

Test plan

  • ./scripts/run-skill-linter.sh rh-sre/skills/fleet-inventory/ passes
  • Invoke /fleet-inventory with "Show the managed fleet" and confirm inventory__list_hosts(per_page=10, page=1) is used
  • Invoke with "What systems are affected by CVE-…?" and confirm vulnerability__get_cve_systems(cve="…") (not cve_id)
  • Confirm inventory__get_host_details is only used with required host_ids after UUIDs are known

Made with Cursor

…arameters

- Added `inventory__list_hosts` and `inventory__find_host_by_name` to the allowed tools.
- Updated documentation to clarify usage of `inventory__list_hosts` for fleet discovery and pagination.
- Revised parameter references for `inventory__get_host_details` and `vulnerability__get_cve_systems` to ensure correct usage.
- Enhanced examples to demonstrate new API patterns and pagination strategies.

This update improves clarity and usability for users interacting with the Fleet Inventory Skill.

Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
- Created a new symlink in the CVE Impact references to point to the Fleet Inventory parameter reference documentation.

This addition enhances the accessibility of parameter references for users working with CVE Impact.

Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
@dmartinol dmartinol requested a review from r2dedios June 22, 2026 09:13

@r2dedios r2dedios left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of observations, Great job!

Comment thread rh-sre/skills/fleet-inventory/SKILL.md Outdated
Comment thread rh-sre/skills/fleet-inventory/SKILL.md Outdated
Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
…se details

- Added `inventory__get_host_system_profile` to the allowed tools for retrieving OS version and system profile.
- Updated descriptions for `inventory__get_host_details` and `inventory__list_hosts` to clarify their functionalities and response structures.
- Revised response fields and examples to reflect the latest API changes, including pagination and filtering strategies.
- Improved clarity on how to handle RHEL version breakdowns and environment tags in the documentation.

This update aims to provide users with comprehensive guidance on utilizing the Fleet Inventory Skill effectively.

Signed-off-by: Daniele Martinoli <dmartino@redhat.com>
@dmartinol dmartinol merged commit 523e305 into RHEcosystemAppEng:main Jun 23, 2026
4 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[rh-sre] fleet-inventory skill: MCP tool and parameter mismatch with Lightspeed MCP schemas

2 participants