Replacing port 25 to 587 for SMTP protocol #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Forgot va_end()...
Author
|
However... like the image below, I didn't manage how to change the output on text "TCP Connect", but the next text is the proof that the port was changed inside |
Author
|
Added a fallback now... so if libmobile fails to use port 587, it will try port 25 before return an error |
Author
|
And now, the config saves this parameter... it's useful for hardware implementations like PicoAdapter |
This reverts commit 093209a.
Author
|
Thanks to @Wit-MKW for this last fix... now tested on PicoAdapterGB and mgba |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tested only on my Pico Adapter and using my Oracle Free Server. It works perfectly. It only replaces port 25 to 587, to avoid issues with ISP that blocks this port. Other port (like 80) will not be affected
Probably, it's possible to set the port as a parameter (like the DNS) further, but I didn't delve into it to do such a thing.
I also added a message to shows when the NO32BIT was trigged (didn't test that)