CImguiSystem improvements#20
Open
Mauler125 wants to merge 11 commits into
Open
Conversation
Mauler125
commented
Jun 25, 2026
Mauler125
commented
- CImguiSystem::IsSurfaceActive() is now of constant time complexity
- Contention on CImguiSystem::m_inputEventQueueMutex has been significantly reduced
- Input will now be dropped immediately if the cursor leaves the game window rect to avoid panels getting stuck/invisible
- Imgui no longer renders if the game window is occluded
- Fixed a memory leak if Dear ImGui initialization failed
- Moved log and cfg files to designated directories to avoid polluting the root dir of the game
- All panels automatically hide if the user clicks on game area, this allows for switching back to game without manually closing
Code will be called very often in a future rework of how the game handles mouse inputs. This limits the maximum number of installable surfaces to 64 (can be increased to 128 if we use sse2, but it is unlikely we will reach 64 in the foreseeable future).
Bitvec allows to figure out which ones exactly were active, but it turns out to be unnecessary. Use a single flag instead so we don't impose any new engine limits.
Scope the auto lock.
Belongs to commit 5db5648
Context must always be destroyed.
Move them to designated locations instead of polluting the root.
This allows the user to directly switch input back to the game, even if they have multiple panels open. No longer need to close them all manually.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.