Zstd net compression#15
Draft
O-Robotic wants to merge 11 commits into
Draft
Conversation
CThreadFastMutex should be CThreadMutex instead, confirmed by code in NET_SendPacket
Add GetHeaderSize and make IsCompressed and GetActualSize static.
Rewritten to support multiple compression algorithms.
Incorrect condition for deciding if nonce should be read or not, should be nSubOutFragmentsAckClamped instead of nSubOutFragmentsAck. Incorrect call to FreeReceiveList, this should only be called after ProcessSubChannelBuffer or after a nonce change. Move CreateFragmentsBuffer hook into CNetChan. Retain the compression mode beyond the function scope.
|
Hi! Any updates on this PR? Has it been tested yet? I’m curious whether it can help reduce server upload/download bandwidth usage and improve the player experience. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP: Implement zstd compression for network traffic and set up infrastructure to allow other compression methods to be used if desired