Skip to content

Conversation

@lg28literconvectionmicrowaveoven

No description provided.

Copy link
Collaborator

@Alystrasz Alystrasz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

I confirm UI to prompt launch args is visible in the settings section, and settings are stored persistently in memory.
However, launching the game with Steam, it appears launch args are not transmitted to Steam.

}

// Grab "Northstar command line arguments" setting from store if possible
const commandLineArgs: { value: String } | null | undefined = await persistentStore.get('northstar-command-line-args');
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On first launch, this would return nothing, leading to an error when starting the game

@lg28literconvectionmicrowaveoven
Copy link
Author

Thanks for the PR!

I confirm UI to prompt launch args is visible in the settings section, and settings are stored persistently in memory.
However, launching the game with Steam, it appears launch args are not transmitted to Steam.

Yes, and quite intentionally so since if a user wishes to have command line arguments exclusively when running off Northstar for some reason they can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants