[BAK-17][refactor] 헬스체크, 동적할당 분리#26
Merged
Merged
Conversation
Contributor
|
리뷰 남겼습니다. |
Contributor
There was a problem hiding this comment.
default Port를 30000번대로 설정하는 건 어떻게 생각하시나요??
이유는 8080포트는 개발할때 주로 사용하는 포트이므로 해당 포트가 비어있더라도 저희가 선점한다면 사용자가 process를 강제로 내릴 가능성도 존재한다고 생각합니다.
Contributor
Author
There was a problem hiding this comment.
네 저도 30000번대 고정이 나을 것 같습니다.
동적할당으로 받게되면 프론트쪽으로 정보전달이 어려울 것 같으니 잘 안쓰는 5자리 포트 사용을 하는 게 좋겠네요.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA Task 🔖
작업 내용 📌