Conversation
| run_step "contracts-bedrock tests setup (go-ffi)" just build-go-ffi | ||
|
|
||
| # temporarily skip failed tests that block CI process | ||
| SKIP_PATH="test/universal/OptimismMintableERC20Factory.t.sol" |
There was a problem hiding this comment.
This case can pass when running on its own.
|
Why are these tests removed:
Are they covered elsewhere? |
| fi | ||
| } | ||
|
|
||
| install_system_package() { |
There was a problem hiding this comment.
Will fail for non-root users on Linux. Either add sudo or guard with a root check.
| run_step "contracts-bedrock build" bash -c "just clean && just forge-build --deny-warnings --skip test" | ||
| popd > /dev/null | ||
|
|
||
| # op-deployer embedded artifacts (required by op-deployer Go tests) |
There was a problem hiding this comment.
Is the removal of op-deployer artifact packing intentional?
There was a problem hiding this comment.
Yes. It was used in supervisor tests, which have been removed.
| # op-e2e-tests | ||
| echo "==========Starting op-e2e-tests..." | ||
| make test-actions | ||
| make test-ws |
There was a problem hiding this comment.
Is the removal of make test-actions/make test-ws intentional?
There was a problem hiding this comment.
Yes, they are covered by go-tests-ci.
|
|
||
| # go-tests-full | ||
| echo "==========Starting go-tests-full..." | ||
| export TEST_TIMEOUT=90m |
There was a problem hiding this comment.
TEST_TIMEOUT=90m is removed, tests may hang indefinitely.
|
What's your criteria to including jobs into this script? |
2 participants
Test script update based on the v1.16.8 merge.
Successfully ran on AX101: Execution time: 61 minute(s) and 54 second(s)