Migrate np.dot(), .dot() methods in test suite to @ operator#798
Draft
Migrate np.dot(), .dot() methods in test suite to @ operator#798
Conversation
Co-authored-by: mmcky <8263752+mmcky@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Migrate np.sum(), np.dot and some .dot() methods in test suite
Migrate np.dot(), .dot() methods in test suite to @ operator
Sep 2, 2025
mmcky
reviewed
Sep 15, 2025
| * x0 | ||
| x_1 = lq_scalar.A * x0 + lq_scalar.B * u_0 + \ | ||
| dot(lq_scalar.C, w_seq[0, -1]) | ||
| lq_scalar.C * w_seq[0, -1] |
Contributor
There was a problem hiding this comment.
@HumphreyYang seems to have picked up the scalar case here.
mmcky
reviewed
Sep 15, 2025
Contributor
mmcky
left a comment
There was a problem hiding this comment.
@HumphreyYang this looks pretty good to me.
From memory there was another pattern we needed to update (is that right?)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR migrates deprecated
np.dot()and.dot()method usage in the test suite to the modern@operator for matrix multiplication, following NumPy best practices.Changes Made
Updated 7 test files with 13 migration patterns:
np.dot(A.T, A)andnp.dot(A.T, np.linalg.solve(R + I, A))to@operator.dot()methods:b1.dot(f1),b2.dot(f2),tfi.dot(aaa[:2, 2])np.dot(x0, P).dot(x0)and removed unusedfrom numpy import dotimport@operatornp.dot()calls to@operatorMigration Examples
Validation
@operatornp.sum()usage reviewed and kept as appropriate for mathematical operationsThis completes the test suite portion of the numpy modernization effort, building on the library code changes that were completed previously.
Fixes #790.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.