fix(azure): add ClusterRegionWithZones type and display AZ count in region selector#2425
Closed
fix(azure): add ClusterRegionWithZones type and display AZ count in region selector#2425
Conversation
…egion selector Add forward-compatible ClusterRegionWithZones interface extending ClusterRegion with an optional zones field. Update the region selector dropdown to display zone count when available from the API. The type augmentation can be removed once qovery-typescript-axios is regenerated from the updated OpenAPI spec.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## staging #2425 +/- ##
===========================================
+ Coverage 47.15% 47.17% +0.02%
===========================================
Files 1252 1259 +7
Lines 23142 23328 +186
Branches 6832 6908 +76
===========================================
+ Hits 10912 11005 +93
- Misses 10151 10204 +53
- Partials 2079 2119 +40
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Update qovery-typescript-axios to 1.1.834 which includes zones on ClusterRegion natively. Remove the temporary extended type.
Displaying zone count adds noise without value — AWS doesn't show it either and Azure regions almost all have 3 AZs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ClusterRegionWithZonesinterface extendingClusterRegionwith optionalzonesfieldFollow-up
Remove
ClusterRegionWithZonestype after updatingqovery-typescript-axiosto includezonesnatively.Files changed
libs/shared/interfaces/src/lib/types/cluster-region-with-zones.type.ts(new)libs/shared/interfaces/src/index.tslibs/pages/clusters/src/lib/ui/page-clusters-create/step-general/step-general.tsxTest plan