Skip to content

refactor: update formatCronExpression util#2420

Merged
rmnbrd merged 1 commit intostagingfrom
impr/cron-expression-condition
Feb 25, 2026
Merged

refactor: update formatCronExpression util#2420
rmnbrd merged 1 commit intostagingfrom
impr/cron-expression-condition

Conversation

@rmnbrd
Copy link
Contributor

@rmnbrd rmnbrd commented Feb 25, 2026

Summary

Tiny change on the formatCronExpression util

Testing

  • Changes tested locally in the relevant Console's pages and Storybooks
  • yarn test or yarn test -u (if you need to regenerate snapshots)
  • yarn format
  • yarn lint

PR Checklist

  • I followed naming, styling, and TypeScript rules (see .cursor/rules)
  • I performed a self-review (diff inspected, dead code removed)
  • I titled the PR using Conventional Commits with a scope when possible (e.g. feat(service): add new Terraform service) - required for semantic-release
  • I only kept necessary comments, written in English (watch for useless AI comments)
  • I involved a designer to validate UI changes if I am not a designer
  • I covered new business logic with tests (unit)
  • I confirmed CI is green (Codecov red can be accepted)
  • I reviewed and executed locally any AI-assisted code

@RemiBonnet
Copy link
Member

Qovery Preview

Qovery can create a Preview Environment for this PR.
To trigger its creation, please post a comment with one of the following command.

Command Blueprint environment
/qovery preview cc1de7de-94e5-40f8-8e45-bc8986d9dfec storybook
/qovery preview 939e824e-ace5-46db-852e-4db251209aeb test-prod-clone
/qovery preview 964984c5-fba6-4371-88d3-a5daf99642ab test-prod
/qovery preview e68a6997-01bc-4a01-adcd-e763ade8d2ae test-prod-clone-pipeline-clone-test
/qovery preview 28c47145-c8e7-4b9d-8d9e-c65c95b48425 staging
/qovery preview {all|UUID1,UUID2,...} To preview multiple environments

This comment has been generated from Qovery AI 🤖.
Below, a word from its wisdom :

Don’t Sacrifice Readability, you are going to debug it in 6 months

@rmnbrd rmnbrd marked this pull request as ready for review February 25, 2026 16:00
@rmnbrd rmnbrd changed the title impr: update formatCronExpression util impr(util): update formatCronExpression util Feb 25, 2026
@rmnbrd rmnbrd changed the title impr(util): update formatCronExpression util refactor: update formatCronExpression util Feb 25, 2026
@codecov
Copy link

codecov bot commented Feb 25, 2026

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 47.15%. Comparing base (cb5821f) to head (54c3251).
⚠️ Report is 1 commits behind head on staging.

Files with missing lines Patch % Lines
...s/shared/util-js/src/lib/format-cron-expression.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           staging    #2420      +/-   ##
===========================================
- Coverage    53.84%   47.15%   -6.70%     
===========================================
  Files          331     1252     +921     
  Lines         6808    23142   +16334     
  Branches      2128     6832    +4704     
===========================================
+ Hits          3666    10912    +7246     
- Misses        2411    10151    +7740     
- Partials       731     2079    +1348     
Flag Coverage Δ
unittests 47.15% <0.00%> (-6.70%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@rmnbrd rmnbrd merged commit ac5bc33 into staging Feb 25, 2026
10 of 13 checks passed
@rmnbrd rmnbrd deleted the impr/cron-expression-condition branch February 25, 2026 16:17
@RemiBonnet
Copy link
Member

🎉 This PR is included in version 1.291.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants