Skip to content

feat(org settings): adding suspense logic and harmonizing skeletons across all settings pages#2418

Merged
TheoGrandin74 merged 3 commits intonew-navigationfrom
feat/new-nav/org-settings-skeletons
Feb 26, 2026
Merged

feat(org settings): adding suspense logic and harmonizing skeletons across all settings pages#2418
TheoGrandin74 merged 3 commits intonew-navigationfrom
feat/new-nav/org-settings-skeletons

Conversation

@TheoGrandin74
Copy link
Contributor

@TheoGrandin74 TheoGrandin74 commented Feb 25, 2026

Summary

Suspense logic and skeletons harmonized for the following pages:

  • Labels & annotations
  • API tokens
  • Git repositories access
  • Helm repositories
  • Container registries
  • Cloud credentials

Screenshots / Recordings

Testing

  • Changes tested locally in the relevant Console's pages and Storybooks
  • yarn test or yarn test -u (if you need to regenerate snapshots)
  • yarn format
  • yarn lint

PR Checklist

  • I followed naming, styling, and TypeScript rules (see .cursor/rules)
  • I performed a self-review (diff inspected, dead code removed)
  • I titled the PR using Conventional Commits with a scope when possible (e.g. feat(service): add new Terraform service) - required for semantic-release
  • I only kept necessary comments, written in English (watch for useless AI comments)
  • I involved a designer to validate UI changes if I am not a designer
  • I covered new business logic with tests (unit)
  • I confirmed CI is green (Codecov red can be accepted)
  • I reviewed and executed locally any AI-assisted code

@RemiBonnet
Copy link
Member

Qovery Preview

Qovery can create a Preview Environment for this PR.
To trigger its creation, please post a comment with one of the following command.

Command Blueprint environment
/qovery preview 15d69f24-9bc1-4a8d-80fe-d1bb1b2bcd00 New Navigation
/qovery preview {all|UUID1,UUID2,...} To preview multiple environments

This comment has been generated from Qovery AI 🤖.
Below, a word from its wisdom :

Programs must be written for people to read, and only incidentally for machines to execute

@codecov
Copy link

codecov bot commented Feb 26, 2026

Codecov Report

❌ Patch coverage is 37.77778% with 56 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (new-navigation@cd3fed9). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...labels-annotations/settings-labels-annotations.tsx 17.94% 30 Missing and 2 partials ⚠️
...s-helm-repositories/settings-helm-repositories.tsx 42.85% 7 Missing and 1 partial ⚠️
.../src/lib/settings-api-token/settings-api-token.tsx 66.66% 3 Missing and 2 partials ⚠️
...ainer-registries/settings-container-registries.tsx 58.33% 4 Missing and 1 partial ⚠️
...pository-access/settings-git-repository-access.tsx 42.85% 3 Missing and 1 partial ⚠️
...s/use-annotations-groups/use-annotations-groups.ts 0.00% 1 Missing ⚠️
...oks/use-helm-repositories/use-helm-repositories.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##             new-navigation    #2418   +/-   ##
=================================================
  Coverage                  ?   45.19%           
=================================================
  Files                     ?      528           
  Lines                     ?    11736           
  Branches                  ?     3377           
=================================================
  Hits                      ?     5304           
  Misses                    ?     5542           
  Partials                  ?      890           
Flag Coverage Δ
unittests 45.19% <37.77%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@TheoGrandin74 TheoGrandin74 merged commit 9b28d7f into new-navigation Feb 26, 2026
10 checks passed
@TheoGrandin74 TheoGrandin74 deleted the feat/new-nav/org-settings-skeletons branch February 26, 2026 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants