Skip to content

Comments

feat(members): adding members to console v5 and tokenization#2413

Open
TheoGrandin74 wants to merge 5 commits intonew-navigationfrom
feat/new-navigation/members
Open

feat(members): adding members to console v5 and tokenization#2413
TheoGrandin74 wants to merge 5 commits intonew-navigationfrom
feat/new-navigation/members

Conversation

@TheoGrandin74
Copy link
Contributor

@TheoGrandin74 TheoGrandin74 commented Feb 23, 2026

Summary

Changes:

  • Adding members to console-v5
  • Switch old buttons logic to new buttons component
  • Switch old ways of handling role switching to a simple select small component
  • Adding disabled state to inputSelectSmall
  • Switch to suspense logic

Screenshots / Recordings

image image image image

Testing

  • Changes tested locally in the relevant Console's pages and Storybooks
  • yarn test or yarn test -u (if you need to regenerate snapshots)
  • yarn format
  • yarn lint

PR Checklist

  • I followed naming, styling, and TypeScript rules (see .cursor/rules)
  • I performed a self-review (diff inspected, dead code removed)
  • I titled the PR using Conventional Commits with a scope when possible (e.g. feat(service): add new Terraform service) - required for semantic-release
  • I only kept necessary comments, written in English (watch for useless AI comments)
  • I involved a designer to validate UI changes if I am not a designer
  • I covered new business logic with tests (unit)
  • I confirmed CI is green (Codecov red can be accepted)
  • I reviewed and executed locally any AI-assisted code

@RemiBonnet
Copy link
Member

Qovery Preview

Qovery can create a Preview Environment for this PR.
To trigger its creation, please post a comment with one of the following command.

Command Blueprint environment
/qovery preview 15d69f24-9bc1-4a8d-80fe-d1bb1b2bcd00 New Navigation
/qovery preview {all|UUID1,UUID2,...} To preview multiple environments

This comment has been generated from Qovery AI 🤖.
Below, a word from its wisdom :

Help yourself at 2AM by putting some metrics to help observability

@codecov
Copy link

codecov bot commented Feb 24, 2026

Codecov Report

❌ Patch coverage is 62.34568% with 61 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (new-navigation@eea7047). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...ture/src/lib/settings-members/settings-members.tsx 68.57% 29 Missing and 4 partials ⚠️
...src/lib/settings-members/row-member/row-member.tsx 48.83% 11 Missing and 11 partials ⚠️
...lib/settings-members/create-modal/create-modal.tsx 70.00% 2 Missing and 1 partial ⚠️
...b/hooks/use-available-roles/use-available-roles.ts 0.00% 1 Missing ⚠️
...lib/hooks/use-invite-members/use-invite-members.ts 0.00% 1 Missing ⚠️
...s/feature/src/lib/hooks/use-members/use-members.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##             new-navigation    #2413   +/-   ##
=================================================
  Coverage                  ?   43.97%           
=================================================
  Files                     ?      957           
  Lines                     ?    18312           
  Branches                  ?     5329           
=================================================
  Hits                      ?     8052           
  Misses                    ?     8796           
  Partials                  ?     1464           
Flag Coverage Δ
unittests 43.97% <62.34%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants