Removal of get_order() and response model fixes#146
Closed
Unt3r wants to merge 7 commits intoQluxzz:masterfrom
Closed
Removal of get_order() and response model fixes#146Unt3r wants to merge 7 commits intoQluxzz:masterfrom
Unt3r wants to merge 7 commits intoQluxzz:masterfrom
Conversation
Models for account_position, transaction
Removed get order
Contributor
|
Oh, just saw your PR after I made #147 |
Owner
|
So, @Unt3r do we close this PR and merge @swechencheng's instead? |
Contributor
Author
|
Yes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed non working get_order() since there is no new endpoint.
Made some fixes to the response models based on testresults for:
account_posititions.py and transaction.py