Update PadDynamicalDecoupling pass to conform to Qiskit 1.3 data model #2047
Merged
kt474 merged 2 commits intoQiskit:mainfrom Nov 20, 2024
Merged
Update PadDynamicalDecoupling pass to conform to Qiskit 1.3 data model #2047kt474 merged 2 commits intoQiskit:mainfrom
PadDynamicalDecoupling pass to conform to Qiskit 1.3 data model #2047kt474 merged 2 commits intoQiskit:mainfrom
Conversation
…ictions. From Qiskit 1.3 DAGNode objects will no longer return references to the same underlying objects, they will be created on the fly. For this reason we need to change the re-parametrization and node id tracking code. Co-authored-by: Raynel Sanchez <raynelfss@hotmail.com>
kt474
approved these changes
Nov 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the
PadDynamicalDecouplingpass to work with the Qiskit 1.3 updates on theDAGCircuitclass. In particular, before this PR, Qiskit/qiskit#12550 would break thetest_insert_midmeas_hahntest fromtest/unit/transpiler/passes/scheduling/test_dynamical_decoupling.py, which is now fixed.If helpful, this PR can also be incorporated into #2041, but thought that it might make sense to separate it given that it's not only changing unit tests. In principle there should be no user-facing changes so no reno was added.
Details and comments
Fixes #