feat(audits): optional read/view auditing (#388)#394
Draft
KofTwentyTwo wants to merge 1 commit intodevelopfrom
Draft
feat(audits): optional read/view auditing (#388)#394KofTwentyTwo wants to merge 1 commit intodevelopfrom
KofTwentyTwo wants to merge 1 commit intodevelopfrom
Conversation
Add ReadAuditLevel (NONE/GET/GET_AND_QUERY) on QAuditRules to track who viewed what data. Async fire-and-forget via shared thread pool. Includes READ handler type, QInstanceValidator checks, and query filter summary in auditDetail records.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ReadAuditLevel(NONE/GET/GET_AND_QUERY) onQAuditRulesto optionally audit read operations (views and queries)AuditHandlerExecutorthread pool -- never blocks or fails readsauditDetailrecords; GET audits have no detailsREADhandler type withReadAuditHandlerInterfacefor custom read audit processingQInstanceValidatorchecks: READ handler code references and audit table existence when readAuditLevel != NONETest plan
ReadAuditActionTestcovering allReadAuditLevelcombinations, InputSource filtering, async isolation, handler invocation, recursion prevention, and auditDetail filter summariesQInstanceValidatorTestfor readAuditLevel validationGetActionTestandQueryActionTestpass with integration changesCloses #388