Feature/follow all exposed joins in input record filter step#6
Merged
darinkelkhoff merged 6 commits intodevelopfrom Mar 24, 2026
Merged
Conversation
… exposed join on a table, including relationships including 'many's. Also expose a class, RecordWorkflowContextJoinedRecordHelper, that application-defined workflow types can use to make their filter steps work the same way. Add large test on InputRecordFilterStep - that tries to do as many versions of 1-n, n-1, n-1-n, 1-n-1, etc, that my friend claude and i could come up with - along with a CompanyHierarchyTablesAndJoinsMetaDataProducer that defines a nice complex set of tables & joins.
…w/ flipped joins)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improves InputRecordFilterStep to correctly handle filters referencing fields across multi-hop joins (including one-to-many and many-to-one relationships) by properly sorting and traversing join paths from the main table outward.
RecordWorkflowContextJoinedRecordHelperthat application-defined workflow types can use for their own filter stepssortQueryJoinsFromMainTableOutward(adapted fromAbstractRDBMSAction) to ensure joins are processed in the correct order when building the cross-productbuildCrossProductto bestaticand take the helper object, making it callable fromRecordWorkflowTypeTesterand custom workflowsreset()method to the helper so cached join records can be cleared after workflow execution (when records may have been persisted)InputRecordFilterStepTestexercising 1:1, 1:N, N:1, and multi-hop join combinationsChore commits
qqq-backend-coreto a tagged branch build that includes the flipped-join validation fixqbit-build-parentto 1.5.1 (Java 21)kingsrook/qqq-orb@0.6Test plan
RecordWorkflowTypeTester.doesFilterMatchworks post-execution afterreset()clears stale cache🤖 Generated with Claude Code