Skip to content

fix(sentinel): deduplicate configured plugins and polish IT release note#23

Merged
PythonWoods-Dev merged 1 commit intomainfrom
fix/v0.5.0a1-final-v2
Apr 2, 2026
Merged

fix(sentinel): deduplicate configured plugins and polish IT release note#23
PythonWoods-Dev merged 1 commit intomainfrom
fix/v0.5.0a1-final-v2

Conversation

@PythonWoods-Dev
Copy link
Copy Markdown
Contributor

Implemented both approved final-mile fixes:

Plugin deduplication:
PluginRegistry.load_selected_rules() now deduplicates config.plugins while preserving declaration order, preventing duplicate rule loading and duplicated side effects.
Italian docs polish:
Corrected release-track sentence in docs/it/about/index.md to proper grammar and accents.
Also added regression coverage:

New test ensures duplicate plugin IDs are loaded once and in deterministic order.
Validation:

Full pre-commit pipeline passed (ruff, mypy, pytest, self-check).

@PythonWoods-Dev PythonWoods-Dev requested a review from Copilot April 2, 2026 17:21
@PythonWoods-Dev PythonWoods-Dev merged commit 40a766f into main Apr 2, 2026
11 checks passed
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves plugin rule loading reliability in Zenzic’s scanner by ensuring configured plugin IDs are deduplicated (preserving declaration order), and polishes a minor Italian documentation sentence about the active release track.

Changes:

  • Deduplicate config.plugins in PluginRegistry.load_selected_rules() while preserving order to avoid duplicate rule loading/side effects.
  • Add a regression test asserting duplicate plugin IDs are loaded once and deterministically ordered.
  • Fix Italian grammar/accents in the docs release-track blurb.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
src/zenzic/core/rules.py Deduplicates requested plugin IDs before resolving/loading entry points.
tests/test_rules.py Adds regression coverage for deduplication + order preservation in plugin loading.
docs/it/about/index.md Corrects Italian sentence for release-line status wording/accents.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@PythonWoods-Dev PythonWoods-Dev deleted the fix/v0.5.0a1-final-v2 branch April 2, 2026 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants