fix(sentinel): deduplicate configured plugins and polish IT release note#23
Merged
PythonWoods-Dev merged 1 commit intomainfrom Apr 2, 2026
Merged
fix(sentinel): deduplicate configured plugins and polish IT release note#23PythonWoods-Dev merged 1 commit intomainfrom
PythonWoods-Dev merged 1 commit intomainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR improves plugin rule loading reliability in Zenzic’s scanner by ensuring configured plugin IDs are deduplicated (preserving declaration order), and polishes a minor Italian documentation sentence about the active release track.
Changes:
- Deduplicate
config.pluginsinPluginRegistry.load_selected_rules()while preserving order to avoid duplicate rule loading/side effects. - Add a regression test asserting duplicate plugin IDs are loaded once and deterministically ordered.
- Fix Italian grammar/accents in the docs release-track blurb.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/zenzic/core/rules.py |
Deduplicates requested plugin IDs before resolving/loading entry points. |
tests/test_rules.py |
Adds regression coverage for deduplication + order preservation in plugin loading. |
docs/it/about/index.md |
Corrects Italian sentence for release-line status wording/accents. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented both approved final-mile fixes:
Plugin deduplication:
PluginRegistry.load_selected_rules() now deduplicates config.plugins while preserving declaration order, preventing duplicate rule loading and duplicated side effects.
Italian docs polish:
Corrected release-track sentence in docs/it/about/index.md to proper grammar and accents.
Also added regression coverage:
New test ensures duplicate plugin IDs are loaded once and in deterministic order.
Validation:
Full pre-commit pipeline passed (ruff, mypy, pytest, self-check).