Support BOM in xml feeds

kloppy/infra/serializers/event/statsperform/parsers/__init__.py

@@ -17,7 +17,7 @@ def get_parser(
 ) -> OptaParser:
     # infer the data format if not provided
     if feed_format is None:
-        if feed.read(1).decode("utf-8")[0] == "<":
+        if feed.read(4).decode("utf-8-sig")[0] == "<":
             feed_format = "XML"
         else:
             feed_format = "JSON"

kloppy/infra/serializers/tracking/tracab/parsers/__init__.py

@@ -18,7 +18,7 @@ def get_metadata_parser(
 ) -> TracabMetadataParser:
     # infer the data format if not provided
     if feed_format is None:
-        if feed.read(1).decode("utf-8")[0] == "<":
+        if feed.read(4).decode("utf-8-sig")[0] == "<":
             feed.seek(0)
             meta_data = objectify.fromstring(feed.read())
             if hasattr(meta_data, "match"):

kloppy/tests/test_statsperform.py

@@ -1,4 +1,5 @@
 from datetime import datetime, timedelta, timezone
+import io
 from pathlib import Path
 
 import pytest
@@ -419,3 +420,33 @@ def test_correct_normalized_deserialization(
                 tracking_system="sportvu",
                 coordinates="kloppy",
             )
+
+
+class TestStatsPerformXMLWithBOM:
+    def test_event_xml_with_bom(
+        self, event_metadata_xml: Path, event_data_xml: Path
+    ):
+        with open(event_metadata_xml, "rb") as f:
+            ma1_data = f.read()
+        with open(event_data_xml, "rb") as f:
+            ma3_data = f.read()
+
+        dataset = statsperform.load_event(
+            ma1_data=io.BytesIO(b"\xef\xbb\xbf" + ma1_data),
+            ma3_data=io.BytesIO(b"\xef\xbb\xbf" + ma3_data),
+        )
+
+        assert len(dataset.records) > 0
+
+    def test_tracking_xml_with_bom(
+        self, tracking_metadata_xml: Path, tracking_data: Path
+    ):
+        with open(tracking_metadata_xml, "rb") as f:
+            ma1_data = f.read()
+
+        dataset = statsperform.load_tracking(
+            ma1_data=io.BytesIO(b"\xef\xbb\xbf" + ma1_data),
+            ma25_data=tracking_data,
+        )
+
+        assert len(dataset.records) > 0

kloppy/tests/test_tracab.py

@@ -1,4 +1,5 @@
 from datetime import datetime, timedelta, timezone
+import io
 from pathlib import Path
 
 import pytest
@@ -392,3 +393,23 @@ def test_correct_deserialization(
         )
 
         meta_tracking_assertions(dataset)
+
+
+class TestTracabXMLWithBOM:
+    def test_correct_deserialization(
+        self, xml_meta_data: Path, dat_raw_data: Path
+    ):
+        # Read the original XML and prepend a UTF-8 BOM
+        with open(xml_meta_data, "rb") as f:
+            xml_data = f.read()
+
+        bom_xml = b"\xef\xbb\xbf" + xml_data
+
+        dataset = tracab.load(
+            meta_data=io.BytesIO(bom_xml),
+            raw_data=dat_raw_data,
+            coordinates="tracab",
+            only_alive=False,
+        )
+
+        meta_tracking_assertions(dataset)