Fix/pipeline#114
Open
faux66 wants to merge 8 commits into
Open
Conversation
Contributor
Author
|
Насколько я понимаю, тесты падают из-за |
f1i3g3
added
bug
f1i3g3
reviewed
May 26, 2026
| list[type[AbstractGoodnessOfFitStatistic]], | ||
| base_class.__subclasses__(), | ||
| ) | ||
| valid_criteria_codes = [cls.code().split("_")[0] for cls in valid_criteria_types] |
Contributor
There was a problem hiding this comment.
Лучше через
valid_criteria_codes = [
cls.code().split("_")[0]
for cls in valid_criteria_types
if not inspect.isabstract(cls)
]
Comment on lines
+162
to
+163
| valid_criteria_codes = [ | ||
| cls.code().split("_")[0] for cls in valid_criteria_types if not getattr(cls, "__abstractmethods__", None) |
Contributor
There was a problem hiding this comment.
На мне расширить документацию тут
Comment on lines
+245
to
+254
| _HYPOTHESIS_TO_BASE_CLASS: dict[Hypothesis, type[Any]] = { | ||
| Hypothesis.NORMAL: AbstractNormalityGofStatistic, | ||
| Hypothesis.EXPONENTIAL: AbstractExponentialityGofStatistic, | ||
| Hypothesis.WEIBULL: AbstractWeibullGofStatistic, | ||
| Hypothesis.GAMMA: AbstractGammaGofStatistic, | ||
| Hypothesis.BETA: AbstractBetaGofStatistic, | ||
| Hypothesis.LOGNORMAL: AbstractLogNormalGofStatistic, | ||
| Hypothesis.STUDENT: AbstractStudentGofStatistic, | ||
| Hypothesis.UNIFORM: AbstractUniformGofStatistic, | ||
| } |
Contributor
There was a problem hiding this comment.
Вынести куда-нибудь повыше?
Comment on lines
+220
to
+239
| elif hypothesis == Hypothesis.GAMMA: | ||
| hypothesis_generator = GammaGenerator() | ||
| generator_name = "GAMMAGENERATOR" | ||
| generator_parameters = [hypothesis_generator.alfa, hypothesis_generator.beta] | ||
| elif hypothesis == Hypothesis.BETA: | ||
| hypothesis_generator = BetaRVSGenerator() | ||
| generator_name = "BETARVSGENERATOR" | ||
| generator_parameters = [hypothesis_generator.a, hypothesis_generator.b] | ||
| elif hypothesis == Hypothesis.LOGNORMAL: | ||
| hypothesis_generator = LognormGenerator() | ||
| generator_name = "LOGNORMGENERATOR" | ||
| generator_parameters = [hypothesis_generator.s, hypothesis_generator.mu] | ||
| elif hypothesis == Hypothesis.STUDENT: | ||
| hypothesis_generator = TRVSGenerator(df=1) | ||
| generator_name = "TRVSGENERATOR" | ||
| generator_parameters = [hypothesis_generator.df] | ||
| elif hypothesis == Hypothesis.UNIFORM: | ||
| hypothesis_generator = UniformGenerator() | ||
| generator_name = "UNIFORMGENERATOR" | ||
| generator_parameters = [hypothesis_generator.a, hypothesis_generator.b] |
Contributor
There was a problem hiding this comment.
Тут бы тоже обобщить в идеале.
f1i3g3
requested changes
May 26, 2026
Contributor
f1i3g3
left a comment
f1i3g3
left a comment
There was a problem hiding this comment.
Кажется, ещё старые тесты валятся, а ещё надо будет новые добавить.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
beta,gamma,lognormal,student,weibull,uniform) with generator classes ingenerators.pya=0.0 → a=1.0generate_lognorm— remove unnecessary np.sqrt(s)generate_uniformimportcommon.py)_get_criteria_config()(C901)